Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Changing row height shows filtered rows | ||||||
---|---|---|---|---|---|---|---|
Product: | Calc | Reporter: | sragavan <sragavan> | ||||
Component: | ui | Assignee: | AOO issues mailing list <issues> | ||||
Status: | CONFIRMED --- | QA Contact: | |||||
Severity: | Trivial | ||||||
Priority: | P3 | CC: | issues, kyoshida, pagalmes.lists | ||||
Version: | OOo 1.1.3 | ||||||
Target Milestone: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Issue Type: | ENHANCEMENT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
sragavan
2004-10-15 05:43:21 UTC
Created attachment 18418 [details]
Proposed patch against OOO113
Hi Niklas, could we implement it ? Not essential but usefull. If possible target 2.0 if not please change. Frank I don't think this is the right way to go. For the related issue 2977 (deleting and formatting cells), the filtered rows are left out of the selection before calling the core methods. We should continue that approach instead of modifying core methods that might be called for different reasons (not in this case). Also, your patch would leave the filtered rows hidden, but still change their heights. sragavan, it's great you look at improving Calc, but I think it would be better to ask before implementing, if your proposed solution fits into the overall picture. This issue remains open, but I'm changing the target to "later". nn: what should be the behaviour in this case as you feel. It shouldnt alter the height of the filtered row?. Can do that nn. Also "the filtered rows are left out of the selection before calling the core methods" Can you give me some pointers towards what these core methods and where this has to be done. Im not a expert in OOo. Just new to it. Help me out.. and i can definetely do that. Issue type: PATCH. For deleting contents, take a look at ScViewFunc::DeleteContents (sc/source/ui/view/viewfunc.cxx), which calls ScViewUtil::UnmarkFiltered to remove the filtered-out rows from the selection. I'm changing the issue type to "enhancement", as we're not going to use the patch, but the suggestion to change the behavior is still valid. When implementing this, it has to be consistent with other filter-related issues (issue 2977, issue 33851). Reset assigne to the default "issues@openoffice.apache.org". |