|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Do not Spell check URLs in Documents | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | frank.loehmann | ||||||||
| Component: | spell checking | Assignee: | michael.ruess | ||||||||
| Status: | CLOSED FIXED | QA Contact: | issues@lingucomponent <issues> | ||||||||
| Severity: | Trivial | ||||||||||
| Priority: | P3 | CC: | ace_dent, adam, andreas.martens, helenrussian, issues, kpalagin, os_ooo, pescetti, rail_ooo | ||||||||
| Version: | 3.3.0 or older (OOo) | Keywords: | oooqa | ||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||||
| Developer Difficulty: | --- | ||||||||||
| Attachments: |
|
||||||||||
|
Description
frank.loehmann
2005-01-07 14:53:39 UTC
If it's not fixed in time for OOo2.0, it should be fixed for OOo2.1. os->fme: I tried to solve it by changing SwTxtNode::Spell() but that is not enough. Also SwScanner::NextWord() has to be changed to treat complete URLs as one word. But I didn't want to break your code ;-) Considering the effort, the priority, the risk and our resource planning I've to retarget this issue to OOo Later. *** Issue 19783 has been marked as a duplicate of this issue. *** *** Issue 55293 has been marked as a duplicate of this issue. *** *** Issue 53645 has been marked as a duplicate of this issue. *** *** Issue 56551 has been marked as a duplicate of this issue. *** This Issue still exists in OOo 2.0.1RC3. A workaround described in duplicate i53645, is to mark the hyperlink as having language = 'None', to avoid spell checking. - Select text - From toolbar 'Format'>'Character...' - Then in 'Font' tab (why? Nothing to do with font?) change Language to '[None]' (First option in list). From the number of duplicate Issues, the fact this breaks a spec and the Issue is now over 1yr old, can a target please be set to fix this? Regards, Andrew Set new target OOo 3.0 . target 3.0 (as fl wanted to set) Created attachment 52064 [details]
Three examples of spell-checked URLs
Are we on track for 3.0 with this issue? Regards, KP. fme->kpalagin: I'll try to fix this for OOo 3.0 but don't dare to give you my word... Please review this simple patch (one liner :) ). If my approach is OK we can change the component to sw. Created attachment 53573 [details]
Proposed patch
Ah, and one line for visited link. Created attachment 53582 [details]
Proposed patch v2
fme->rail: Thank you for your patch. I think we use your patch but we have to keep in mind that this only works for new documents. I also set the LANGUAGE_NONE for the CTL and CJK language. Patch has been applied to cws sw30bf04. rail->fme: great! Thanks for prompt fix and cws. Changes in sw30bf04 worked fine for me. Ready for QA. Please note that the fix works by setting the language of the hyperlink character formats to "none". Therefore this fix applies to new documents. Verified fix in CWS sw30bf04. Checked fix in DEV300 m24, but should already be available in OO30_beta2. |