Issue 40959

Summary:	dmake create_patch should produce unified diffs
Product:	Build Tools	Reporter:	rene
Component:	solenv	Assignee:	lohmaier
Status:	CLOSED FIXED	QA Contact:	issues@tools <issues>
Severity:	Trivial
Priority:	P3	CC:	hdu, issues, pavel, quetschke, sparcmoz
Version:	current
Target Milestone:	---
Hardware:	All
OS:	All
Issue Type:	ENHANCEMENT	Latest Confirmation in:	---
Developer Difficulty:	---

Description rene 2005-01-19 11:36:40 UTC

Hi, 
 
unified diffs are FAR better to read than context diffs. They are the standard 
form of submitting patches. Please change dmake create_patch to create unified 
diffs and probably change the existing patchfiles ;) 
 
Regards, 
 
Rene

Comment 1 pavel 2006-08-29 07:25:08 UTC

+1

Comment 2 hjs 2008-02-25 15:51:40 UTC

see the change in solenv/inc/tg_ext.mk:
diff -rc -> diff -ru

Comment 3 hjs 2008-02-25 17:04:00 UTC

Comment 4 hjs 2008-03-04 10:09:43 UTC

please verify

Comment 5 lohmaier 2008-03-04 21:05:43 UTC

verified in cws ause090

Comment 6 thorsten.ziehm 2009-07-21 13:54:25 UTC

This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues