Issue 43592

Summary:

64bit: Make help working

Product:

porting

Reporter:

pavel

Component:

code

Assignee:

pavel

Status:

CLOSED FIXED

QA Contact:

issues@porting <issues>

Severity:

Trivial

Priority:

CC:

issues, kendy, Mathias_Bauer, nesshof

Version:

current

Target Milestone:

OOo 2.0

Hardware:

All

OS:

All

Issue Type:

PATCH

Latest Confirmation in:

---

Developer Difficulty:

---

Attachments:

Description	Flags
help (pages without images) works now!	none

Description pavel 2005-02-26 17:49:02 UTC

Hi,

the attached patch clarifies types in the following functions:

sfx2/inc/sfxbasemodel.hxx: getSomething

and

sfx2/source/doc/objxtor.cxx:SfxObjectShell::CreateObject

It is not correct solution (or is it?), because it is changing the prototype
from sal_Int64 to sal_IntPtr, but at least it make help pages (with the
exception of help pages with images) working on AMD64.

mba: please have a look and provide correct solution ;-)

Comment 1 pavel 2005-02-26 17:50:10 UTC

Created attachment 23062 [details]
help (pages without images) works now!

Comment 2 Mathias_Bauer 2005-02-28 09:29:16 UTC

Sorry, but this patch doesn't work.

You can't change the return type of a method defined by an IDL interface.
Does it work if you change the code in the following way:

in objxtor.cxx:

sal_Int64 nHandle = xObj->getSomething( aSeq );
if ( nHandle )
    return (SfxObjectShell*) (sal_IntPtr) nHandle;

in sfxbasemodel.cxx

if ( aName == SvGlobalName( SO3_GLOBAL_CLASSID ) )
    return (sal_Int64)(sal_IntPtr)(SvObject*)GetObjectShell();
else if ( aName == SvGlobalName( SFX_GLOBAL_CLASSID ) )
    return (sal_Int64)(sal_IntPtr)(SfxObjectShell*)GetObjectShell();

sfxbasemodel.hxx stays unchanged now.

Comment 3 pavel 2005-03-05 12:15:03 UTC

mba: works OK.

Committed in ooo64bit02.

Thanks!

Comment 4 pavel 2006-05-01 10:54:00 UTC

Closing.