Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | A dot in find string of Help Viewer loops (crashes) the Office | ||
---|---|---|---|
Product: | documentation | Reporter: | Uwe Fischer <uwefis> |
Component: | Online help | Assignee: | h.ilter |
Status: | CLOSED FIXED | QA Contact: | issues@documentation <issues> |
Severity: | Trivial | ||
Priority: | P2 | CC: | issues |
Version: | current | ||
Target Milestone: | OOo 2.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
Uwe Fischer
2005-05-27 12:18:55 UTC
UFI: I just found that the Help Viewer does not enter an endless loop. It just needs a very looooong time to select all characters on the help page. So you may reset the prio from 2 to 3 if you want ABI->FME: Apparently, after doing the search, the search text will be marked in the writer window on the right panel using writer functionality. Here is a snapshot of the stack, SetSelection is the method which does not return. sw680mi.dll!SwNodeIndex::SwNodeIndex() + 0x32 C++ sw680mi.dll!SwPosition::SwPosition() + 0x12 C++ sw680mi.dll!SwCrsrShell::MakeFindRange() + 0x3b C++ sw680mi.dll!SwCrsrShell::MakeFindRange() + 0x83 C++ sw680mi.dll!SwCrsrShell::ClearUpCrsrs() + 0x2b C++ sw680mi.dll!SwCrsrShell::UpdateCrsr() + 0x1a C++ sw680mi.dll!SwCrsrShell::CreateCrsr() + 0xa1 C++ sw680mi.dll!SwCrsrShell::SetSelection() + 0x52 C++ FME->PB: Please have a look at sfx2/source/appl/newhelp.cxx, PrepareSearchString(). If 'normal.dot' is passed as parameter, the resulting search string will be 'normal|.|dot'. Using this for a regexp search will find every single character, giving us a loop-like behaviour. pb: you can not search for strings like "normal.dot" because our search engine takes the dot as a word break. So here we are searching for the strings "normal" and "dot". But I fixed the "loop". Fixed in cws fwk16. Files changed: /sfx2/source/appl/newhelp.cxx 1.110.62.2 Which search engine is involved here? Is the same engine used for searching as for marking the strings on the page? How do I search for a "." then? We should offer the simplest functionality to the user and that is: search for the literal that is entered in the search field. Don't assume the users know about "word boundaries" or "wild cards". Retargetted due to importance of the issue. pb -> hi: please verify, thx. re-open issue and reassign to hi@openoffice.org reassign to hi@openoffice.org reset resolution to FIXED Verified with cws fwk16 = ok Verified with 680m119 = ok |