Issue 50820

Summary: 'hotfix' == memory leak ...
Product: gsl Reporter: mmeeks <mmeeks>
Component: codeAssignee: hdu <hdu>
Status: CLOSED DUPLICATE QA Contact: issues@gsl <issues>
Severity: Trivial    
Priority: P3 CC: issues
Version: 680m109   
Target Milestone: ---   
Hardware: Other   
OS: All   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---

Description mmeeks 2005-06-16 12:50:15 UTC
Looks like this (lazy/fast) fix needs re-visiting, I'm seeing some substantial
leakage from this:

--- vcl/source/gdi/outdev3.cxx  18 May 2005 08:04:00 -0000      1.200
+++ vcl/source/gdi/outdev3.cxx  16 Jun 2005 11:53:43 -0000
@@ -1599,7 +1599,7 @@
     {
         ImplFontData* pFace = mpFirst;
         mpFirst = pFace->GetNextFace();
-#if 0 // HOTFIX for 122732
+#if 1 // HOTFIX for 122732
         delete pFace;
 #endif
     }

That fixes the leak ;-) - what the HOTFIX is supposed to fix I have no idea;
it'd be nice to get the details from that.
Comment 1 philipp.lohmann 2005-06-16 13:19:10 UTC
pl->hdu: he got you :-)
Comment 2 hdu@apache.org 2005-06-16 13:27:01 UTC
The leak was fixed in issue 50820. It was still better than a crash :-)

*** This issue has been marked as a duplicate of 50546 ***
Comment 3 hdu@apache.org 2005-06-16 13:47:34 UTC
Closing duplicate.