Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing
|Summary:||ux-ctest: Summation does not work from UI; changes exsisting value|
|Status:||CLOSED FIXED||QA Contact:||issues@sc <issues>|
|Priority:||P2||CC:||issues, kpalagin, rail_ooo, sgautier.ooo|
|Issue Type:||PATCH||Latest Confirmation in:||---|
Description einstienindia 2005-07-05 09:13:43 UTC
Steps: - Open calc. - fill values A1=1,A2=2,A3=3 - select A1,A2,A3 - click on "SUM" symbol in the "formula" toolbar All the selected values becomes 0 or #REF! If it is not summing up the values at least it should not change the exsisting values !! On excel the same steps result in the summation in A4. Manually typying "=SUM(A1:A3)" works fine Also happens on 1.1.4
Comment 1 frank 2005-07-12 15:09:54 UTC
Hi, this has never worked in Calc, therefore this is an enhancement request. I've reflagged this Issue and re-assign it to the requirements team. Please have a look at Issue 42309 also, this seems to be related. Frank
Comment 2 frank 2006-01-12 11:39:16 UTC
*** Issue 60407 has been marked as a duplicate of this issue. ***
Comment 3 frank.loehmann 2006-01-12 12:02:11 UTC
This feature is on the UX requirements list (see 60407) for OOo 3.0. Therfore I have adjusted prio and target milestone.
Comment 4 drensink 2006-04-09 20:02:08 UTC
*** Issue 63920 has been marked as a duplicate of this issue. ***
Comment 5 frank.loehmann 2006-05-30 09:00:27 UTC
Comment 6 frank.loehmann 2006-06-12 13:10:13 UTC
FL: No ressources for OOo 2.0.4 -> new target OOo 2.x
Comment 7 frank.loehmann 2006-08-03 14:05:36 UTC
Added keyword to issue title.
Comment 8 frank 2006-10-27 13:02:42 UTC
*** Issue 70778 has been marked as a duplicate of this issue. ***
Comment 9 kpalagin 2006-10-27 20:26:52 UTC
I also would suggest the following enhancement to this feature: 1. Holding Ctrl while clicking Sum should insert sum above the selection. 2. Holding Shift should insert sum to the right of the range. 3. Holding both Ctrl and Shift should insert sum to the left of the range.
Comment 10 kpalagin 2006-12-11 21:28:27 UTC
Any chance for 2.2? (Converts from competing products badly suffer without this feature). Thanks a lot.
Comment 11 mloiseleur 2007-03-25 22:47:03 UTC
Created attachment 43921 [details] Patch to implement this feature
Comment 12 mloiseleur 2007-03-25 22:52:15 UTC
Hello there, I have made the patch to implement this feature. It's a small one so I give it a try. I have tried to test different scenarios (text cell, formula cell, value) and they all seems to work. It was really hard to do, Calc code is not an easy one. Regards,
Comment 13 sgautier.ooo 2007-03-26 08:47:29 UTC
adding me to cc - Sophie
Comment 14 frank 2007-03-26 11:22:18 UTC
Hi Niklas, please have a look at the attached patch. Frank
Comment 15 rail_ooo 2007-03-27 22:37:16 UTC
2 mloiseleur: Seems like this patch doesn't create "=SUM(...)" formula, it just calculates sum of the selected cells and operates with value. Additionally it doesn't work as expected. Here is my testing scenario: A1 -> 1 A2 -> 2 A3 -> 3 Select A1:A3 and press SUM icon. Instead of putting 6 into A4 it puts 6 (by value, not formula) into A1, A2 and A3, changing the original values to summed. After it we have: A1 -> 6 A2 -> 6 A3 -> 6
Comment 16 mloiseleur 2007-03-31 23:02:08 UTC
Created attachment 44109 [details] A better version, which puts the formula and not the result
Comment 17 mloiseleur 2007-03-31 23:03:23 UTC
Oh. I haven't read it carefully. Here is a corrected version of the patch. Here is the scenario tested : fill values A1=1,A2=2,A3=3 fill values A1=1,B1=2,C1=3 fill values C3=15 If you select A1:A3 Range and clic on sum, you get =SUM(A1:A3) in A4 If you select A1:C1 Range and clic on sum, you get =SUM(A1:C1) in D1 If you select A1:C3 Range and clic on sum, you get =SUM(A1:C3) in C4 Is there anything else missing ? Maybe one day the sum will follow the way selection is done. i.e. : - When you select from left to right A2:A4, pum sum in A5 - When you select from right to left A2:A4, pum sum in A1 But not for this issue, I think.
Comment 18 rail_ooo 2007-04-01 09:45:38 UTC
mloiseleur: thanks for you effort! The latest patch works better. I made some tests and here is some notes. 1. this feature doesn't work as expeced if you select cells from the bottom. A1:A3 selection works fine but not A3:A1. The same for horizontal selection. 2. A65534:A65536 sum doesn't work :). It rises warning box "Cannot change protected cells". :p Anyway, it's very good usability enhancement. Thanks again.
Comment 19 mloiseleur 2007-04-01 12:55:24 UTC
2 rail : "1. this feature doesn't work as expeced if you select cells from the bottom. A1:A3 selection works fine but not A3:A1. The same for horizontal selection." It was like this before my patch ... damn, there is really something different when you select from bottom to top or from top to bottom ... "2. A65534:A65536 sum doesn't work :). It rises warning box "Cannot change protected cells". :p" :). I will take a look at it. But I don't see where to put the sum in this case. The error message is fine for me. Do you have any better idea ?
Comment 20 mloiseleur 2007-04-01 13:39:59 UTC
Created attachment 44126 [details] 3rd release of the patch
Comment 21 mloiseleur 2007-04-01 13:43:50 UTC
First point is fixed in the third release of the patch. For second point, I consider it not applicable, until someone have a good answer. The error message is fine by me. Is there someone in the plane with cvs access ? I think it's ready for integration. thanks rail for your comments,
Comment 22 rail_ooo 2007-04-01 20:42:37 UTC
3rd patch is "ideal". :) I have no idea how to handle the situation when you try to sum cells at the end of the sheet, maybe current solution is enough. I can offer myself as QA person for this CWS. ;)
Comment 23 mloiseleur 2007-04-08 10:53:00 UTC
Created attachment 44276 [details] 4th release, with a sum for each col
Comment 24 mloiseleur 2007-04-08 10:55:26 UTC
Thanks to kpalagin, it pointed to me the difference with the competitor. I have kept the line sum, which is not present in it, and added the fact that the sum is for each columns of a range. The 'column-wise' version is in the 4th release of the patch. Regards,
Comment 25 rail_ooo 2007-04-08 11:54:45 UTC
mloiseleur: thanks for update. I can test and review the latest patch durung next week.
Comment 26 thomas.benisch 2007-04-23 12:22:16 UTC
TBE->MLOISELEUR: Thanks for your patch. I tested the 4th release of this patch and found some further issues: 1. subtotals don't work You removed the working code for subtotals, therefore subtotals don't work neither in the old scenario (select 2 empty cells in two different columns) nor in the new one (select 3 non-empty cells in one column). 2. autosum for two columns/rows is not working If you have two columns with non-empty cells A1:A3 and B1:B3, select A4 and B4 and press the sum button, then cell C4 gets the formula SUM(A4:B4). 3. autosum with empty cells in the selection adds the result in the wrong cell (#i60397#) If you have a column with non-empty cells A1:A3 and an empty cell A4, select A1:A4 and press the sum button, then the result formula should be added to A4. If you don't object I will fix the remaining issues and care for the integration of this patch.
Comment 27 mloiseleur 2007-04-23 12:29:23 UTC
MLO->TBE: I have no objection at all :). I do not know how to make subtotal works, so feel free to reactivate it. Thanks.
Comment 28 kpalagin 2007-04-23 13:03:30 UTC
tbe, mloiseleur, thank you very much for your attention. tbe, can we emulate following competitor's behavior - if I select empty column to the right, Excel will insert row-wise SUMs in that additional column? They will do insert only below or to the right, we can do all 4 ways.
Comment 29 thomas.benisch 2007-04-24 08:38:14 UTC
> can we emulate following competitor's behavior - if I select empty column to > the right, Excel will insert row-wise SUMs in that additional column? I think it's quite tricky to handle all the different use cases, but I'll try my best. > They will do insert only below or to the right, we can do all 4 ways. What do you mean by all 4 ways?
Comment 30 kpalagin 2007-04-24 08:46:16 UTC
By sayin 4 ways I mean if we select additional empty column to the right of our data we should generate row-wise sums in that column, additional empty row below our data we should generate column-wise sums in that row, additional empty column to the LEFT of our data we should generate row-wise sums in that column, additional empty row ON TOP of our data we should generate column-wise sums in that row, Excel will do first two, but not the last two.
Comment 31 niklas.nebel 2007-05-07 15:04:27 UTC
tbe is taking care of this.
Comment 32 thomas.benisch 2007-05-21 12:43:42 UTC
Comment 33 thomas.benisch 2007-06-01 10:29:23 UTC
The specification is available at http://specs.openoffice.org/calc/ease-of-use/autosum.odt
Comment 34 mloiseleur 2007-06-01 10:43:34 UTC
Impressive. 10 pages for this patch. Thanks and keep up the good work. I wasn't thinking one second that our patch would need this kind of documents. Does this document signify an integration for OOo 2.3 ? Regards,
Comment 35 thomas.benisch 2007-06-01 11:10:18 UTC
> Does this document signify an integration for OOo 2.3 ? No, it's just another step in this direction. You can watch the progress by observing the state of the CWS calcautosum (planned, new, ready for QA, approved by QA, nominated, integrated). Right now the state is still new.
Comment 36 thomas.benisch 2007-06-01 11:11:16 UTC
fixed in CWS calcautosum
Comment 37 thomas.benisch 2007-06-05 16:23:14 UTC
TBE->FST: Please test on CWS calcautosum.
Comment 38 rail_ooo 2007-06-05 16:32:34 UTC
tbe, can you attach calcautosum patch for testing purpose?
Comment 39 frank.loehmann 2007-06-20 08:29:29 UTC
*** Issue 60397 has been marked as a duplicate of this issue. ***
Comment 42 frank 2007-06-20 13:35:18 UTC
found fixed on cws calcautosum using Windows and Solaris build
Comment 43 frank 2007-06-20 13:40:05 UTC
Comment 44 frank 2007-06-20 14:37:29 UTC
Created attachment 46096 [details] corrected testcasespecification
Comment 45 frank 2007-06-20 14:38:48 UTC
Created attachment 46097 [details] added another test to case 1.
Comment 46 frank 2007-08-22 16:01:58 UTC
found integrated on Master OOG680m1 using Solaris, Windows and Linux build.
Comment 47 burgrettici 2010-11-10 16:37:09 UTC
Created attachment 73238