Issue 53749

Summary: slideshow option Show Logo doesnt work
Product: Impress Reporter: avagula
Component: viewingAssignee: Ariel Constenla-Haile <arielch>
Status: CLOSED FIXED QA Contact: issues@graphics <issues>
Severity: Trivial    
Priority: P3 CC: arielch, doneyourself, hanya.runo, issues
Version: 680m123   
Target Milestone: 4.0.0   
Hardware: All   
OS: All   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
Patch to reflect to show/hide logo none

Description avagula 2005-08-24 19:02:49 UTC
In community builds in Impress slideshow settings the option 'Show logo' doesnt
work, ie. no OO.o logo is displayed during pause between two slides.
Comment 1 wolframgarten 2005-08-25 07:58:48 UTC
Reproducible. Reassigned.
Comment 2 thb 2005-08-25 09:55:30 UTC
@cl: seems to be a missing resource bitmap - is that you or mh?
Comment 3 christian.guenther 2007-06-14 14:27:11 UTC
*** Issue 78421 has been marked as a duplicate of this issue. ***
Comment 4 hanya 2012-05-16 09:10:27 UTC
Created attachment 77553 [details]
Patch to reflect to show/hide logo

The logo is always shown in the roop mode.
Comment 5 Ariel Constenla-Haile 2012-05-25 11:38:12 UTC
(In reply to comment #4)
> Created attachment 77553 [details]
> Patch to reflect to show/hide logo
> 
> The logo is always shown in the roop mode.

@hanya: the patch looks ok. Do you have commit rights to commit it?
Comment 6 hanya 2012-05-25 11:57:53 UTC
(In reply to comment #5)
> @hanya: the patch looks ok. Do you have commit rights to commit it?
No I don't.
Comment 7 Ariel Constenla-Haile 2012-05-25 12:04:52 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > @hanya: the patch looks ok. Do you have commit rights to commit it?
> No I don't.

Ok, I can commit the patch if you confirm here, in this bug, that you are contributing it under the Apache License v. 2.0.

Note that it would be nice if you think about signing the Individual Contributor License Agreement (ICLA) for your future contributions, as it makes the workflow of submitting patches easier. You can find more info in
http://www.apache.org/dev/new-committers-guide.html#cla
http://www.apache.org/licenses/icla.txt
Comment 8 hanya 2012-05-28 14:39:28 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > @hanya: the patch looks ok. Do you have commit rights to commit it?
> > No I don't.
> 
> Ok, I can commit the patch if you confirm here, in this bug, that you are
> contributing it under the Apache License v. 2.0.
> 
> Note that it would be nice if you think about signing the Individual
> Contributor License Agreement (ICLA) for your future contributions, as it
> makes the workflow of submitting patches easier. You can find more info in
> http://www.apache.org/dev/new-committers-guide.html#cla
> http://www.apache.org/licenses/icla.txt
I sent signed ICLA and it was filed in ASF, I responsed by Sam.
Comment 9 Ariel Constenla-Haile 2012-05-28 16:27:55 UTC
Committed as Revision 1343311

@hanya: Thanks for your efforts. Keep up the good work.
Comment 10 hanya 2012-05-28 16:47:55 UTC
@ariel Thanks to commit the patch.
Comment 11 liuping 2012-06-21 09:23:03 UTC
confirm fixing the bug on ver 1351249 in Win7 ,pass