Issue 54401

Summary: Spellcheck dialog, context menu and character attributes
Product: Writer Reporter: thomas.lange
Component: codeAssignee: AOO issues mailing list <issues>
Status: ACCEPTED --- QA Contact:
Severity: Trivial    
Priority: P3 CC: issues, stefan.baltzer
Version: OOo 2.0   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Description Flags
Sample bug document
Displays why the error is caused none

Description thomas.lange 2005-09-09 13:42:23 UTC
Load attached bug doc and replace misspelled words by using the spellcheck
dialog or the context menu from right mouse button click.
Only the first line gets the expected attributation for the corrected word.

Need to be fixed for Writer and EditEngine (textboxes, Calc, Draw, Impress).

TL->OS: The thing that needs to be done is that prior to setting the attributes
of the new inserted text all attributes must be removed.
For Writer: ResetAttr from wrtsh has to be called
For svx: RemoveAttribs() on the edit view has to be called. MT made the required
fixes for this to work in CWS textconversion in the function
 EditDoc::RemoveAttribs( ContentNode* pNode, USHORT nStart, USHORT nEnd,
EditCharAttrib*& rpStarting, EditCharAttrib*& rpEnding, USHORT nWhich ) from
file editdoc.cxx
Comment 1 thomas.lange 2005-09-09 13:43:52 UTC
Created attachment 29427 [details]
Sample bug document
Comment 2 thomas.lange 2005-09-09 13:45:53 UTC
TL->OS: Please take over. Thanks!
TL->SBA: Target OOo3.0?
Comment 3 thomas.lange 2005-09-12 13:04:09 UTC
Comment 4 amouzgar 2006-01-27 04:28:28 UTC
I tried to replicate the error by typing the exact same sequence of characters
as in SpellCheckAndAttributes.sxw in a new text document. To my surprise the
error did not occur. I made sure that all the characters including new line
characters in the 2 files are identical and still got the same results. 

I found something interesting about the problem. 

In the text given in SpellCheckAndAttribute.sxw the font of the  'space
character' immediately before and after 'Thiss' on the 2nd and 3rd lines
respectively is different from the rest of the document. This is not explicitly
visible as only the font of the 2 spaces are different.

To support this:

we can place the cursor on the second line  right before 'Thiss' and type
something. It is going to be typed in the small blue font that the replaced
suggestion appears in when the misspelled word on that line is replaced. 

Similarly we can place the cursor on the 3rd line right after 'Thiss' and type
something it is going to be typed in the small pink vertical font  the replaced
suggestion appears in when the misspelled word on that line is replaced. In
other words.


It looks like the real source of the problem is the fact that spell checker,
while replacing mis-spelled words, chooses the font of the character immediately
before the  mis-spelled word for the suggestion. 

This was tested and the results were supporting the idea.

Here's how I tested it.

1- open new text document
2- write 'This is not a big mistaak , a small problem in fact' . 
3- Place the cursor before 'mistaak'.
4- change the font to something different and the color to say red and  type a
5- now place the cursor right after 'big' and press the delete button to delete
the extra space from the front of it. 

The text looks exactly the same as the previous one but if we run the spell
checker and replace 'mistaak' with some suggestion, the suggestion is going to
be written in the font that we previously chose for the space character.

See the 2nd attached file and run the spell checker on it. The lines look
identical except for that white space in a different font  before 'mistaak'.
Comment 5 amouzgar 2006-01-27 04:32:18 UTC
I performed all the experiments on a kernel 2.4.31 Red Hat machine on ooffice 2.
Comment 6 amouzgar 2006-01-27 04:44:36 UTC
Created attachment 33602 [details]
Displays why the error is caused
Comment 7 thomas.lange 2006-01-30 09:34:56 UTC
The problem is not about the characters. It is about their attributes.
Comment 8 Oliver Specht 2006-05-29 08:04:22 UTC
Target set to OOo 3.0
Comment 9 Oliver Specht 2006-06-20 13:15:42 UTC
Target adjusted
Comment 10 Martin Hollmichel 2007-09-10 13:35:58 UTC
move target to 3.x according
Comment 11 hardy314 2009-08-22 20:29:54 UTC
This malbehavior is still present in OO 3.1. I voted for it and hope that it
will be fixed soon.
Comment 12 Marcus 2017-05-20 11:17:50 UTC
Reset assigne to the default "".