Issue 55007

Summary: Update charts in writer should be automatic, or at least more accessible
Product: Writer Reporter: openoffice.org
Component: uiAssignee: michael.ruess
Status: CLOSED FIXED QA Contact: issues@sw <issues>
Severity: Trivial    
Priority: P3 CC: IngridvdM, issues, rb.henschel
Version: OOO 2.0 Beta2Keywords: oooqa, rfe_eval_ok, usability
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: ENHANCEMENT Latest Confirmation in: ---
Developer Difficulty: ---

Description openoffice.org 2005-09-23 19:21:38 UTC
Writer does not update diagram when table data is adjusted

Steps to reproduce:
1. create a new table (e.g. 2x2)
2. fill it with numbers
3. Select all sels (whole table)
4. Choose: "Insert > Object > Chart"
5. Just complete wizzard for default chart, doesn't really matter
6. Change some values in one of the cells

What does not happen is that the chart is updated automatically, which is
expected result (the desired effect occurs in calc).

Even worse is that the only way I have been able to discover to update the chart
is hidden under "Tools > Update > All Charts". There should be an easier way to
do this. Automatic is preferable, but an 'update this chart'-button (when the
chart is selected) would be a great improvement already.
Comment 1 Regina Henschel 2005-09-23 20:13:51 UTC
I use German OOo1.9.125 on WinXP. The behavior is slightly different. The chart
updates, if you chance a cell, which containes a number. It doesn't update if
you change a row or column which is used as caption. The caption is updated as
soon as you change a number. So there seems to be a defect.

You can customize your toolbar to get a button for updating. It is the entry
"All Charts" in the category "Edit". But it has no default icon.

Because this is about the special writer-chart I do not know, if it belongs to
component "Chart".
Comment 2 openoffice.org 2005-09-23 22:14:09 UTC
I filed it for the component 'word processor' ;), also because the thing I
noticed only happened in the word processor (btw also 1.9.125 EN ('the standard
version?')). The behaviour in Calc was as expected (also captions are being
updated here).

What I did notice however is that when a new row is created, the Chart get's
updated. But still. Maybe the best option to get this temporary fixed as soon as
possible would be to put the update all charts button in the Charts-toolbar
(with a nice icon ;) ).
Comment 3 michael.ruess 2005-09-26 16:42:17 UTC
The chart will be updated every time the cursor will leave the table.
But in times of GHz computers, it should be possible to offer a kind of
"live-update".
Comment 4 openoffice.org 2005-09-26 19:47:05 UTC
The live update function is indeed an enhancement (a better solution to the
problem stated). Yet I would think of the difficulty to find any update function
where expected (in the context menu, or in the diagram-menu-bar) as a UI defect.
I submitted this bug as I had to ask on a mailinglist where to find this
function (but maybe it's just me who has a problem with the current situation).

I believe a simple repair of this UI-problem would be just a button on the
context-sensetive menubar. The 'Tools > Update > All Charts' should only be used
to update all charts, not just a single chart, imho.

The edit table function (which is available when you don't select a writer-table
fo the diagram) is far more easier to handle.
Comment 5 zumbi 2006-11-05 18:19:06 UTC
I confirm that the chart doesn't get updated even when the cursor is moved out
of the table. This used to work with OOo versions earlier than 2.0. This is
still true with version 2.0.4.

I'm glad this bug report exists, and mentions the "Tools -> Update -> All
charts"  command. Until I found this report, I couldn't figure out any way to
update charts in Writer. This is really an interface usability bug!

To quickly reproduce this issue, you can reuse this document:
http://free-electrons.com/issues/ooo/nov5-2006/chart.odt

Cheers,

Michael.

Comment 6 IngridvdM 2006-11-16 21:50:52 UTC
->tl: When you implement the update for the new chart please consider if it
would be easier to use this more desireable solution. If so I would vote to
remove those extra update menu entries and replace them by a live update as the
users are used to from the calc. But there might be a problem when charts are
not loaded.
Comment 7 IngridvdM 2006-11-16 21:52:10 UTC
added me to CC
Comment 8 thomas.lange 2006-12-14 11:52:32 UTC
.
Comment 9 thomas.lange 2007-01-29 13:56:08 UTC
Fixed in CWS chart2mst2.
Currently only a repaint problem remains to be solved.

Files changed:


sw/inc/IDocumentChartDataProviderAccess.hxx
sw/inc/doc.hxx
sw/inc/swtable.hxx
sw/inc/unochart.hxx

sw/source/core/doc/docchart.cxx
sw/source/core/doc/doclay.cxx
sw/source/core/doc/docnew.cxx
sw/source/core/doc/docsort.cxx
sw/source/core/doc/tblrwcl.cxx
sw/source/core/docnode/ndtbl.cxx
sw/source/core/edit/editsh.cxx
sw/source/core/edit/edtab.cxx
sw/source/core/text/txtfrm.cxx
sw/source/core/txtnode/ndtxt.cxx
sw/source/core/undo/untbl.cxx
sw/source/core/unocore/unochart.cxx
sw/source/core/unocore/unocoll.cxx
sw/source/core/unocore/unotbl.cxx
sw/source/ui/shells/textsh.cxx
sw/source/ui/table/chartins.cxx
sw/source/ui/uno/unotxdoc.cxx
Comment 10 thomas.lange 2007-01-29 15:00:15 UTC
Further changes:
The checkbox in the dialog "Tools/Options/Star Office Writer/General" named
"Charts" is now indented the same level as the "Fields" box. Also
enabling/disabling the "Field" box does not have an effect on the "Chart" boy
anymore.
Thus toggling of automatic updates for charts is now fully a flag on it's own.
If that flag is set and changes to a chart are made those changes will become
available a moment after the cursor leaves the current cell. And this is right
after formula fields in a table get updated, thus chart will get the correct
value for every field.

- sw/source/ui/config/optload.cxx
- sw/source/ui/config/optload.src
Comment 11 thomas.lange 2007-02-01 13:40:03 UTC
Also changed:
- framework/embeddedobj/source/general/docholder.cxx
Comment 12 thomas.lange 2007-02-02 11:24:14 UTC
Repaint problem solved for both:
- newly inserted chart  and
- chart within a loaded document

Files changed:
- sw/inc/docsh.hxx
- sw/source/core/doc/docchart.cxx
- sw/source/core/doc/tblrwcl.cxx
- sw/source/core/docnode/ndtbl.cxx
- sw/source/core/edit/edtab.cxx
- sw/source/core/unocore/unochart.cxx
- sw/source/core/unocore/unoframe.cxx
- sw/source/ui/app/docsh.cxx
- sw/source/ui/wrtsh/wrtsh1.cxx
Comment 13 thomas.lange 2007-02-02 11:24:32 UTC
.
Comment 14 thomas.lange 2007-02-08 08:21:03 UTC
.
Comment 15 thomas.lange 2007-02-19 12:22:13 UTC
Works fine in latest build.
Comment 16 IngridvdM 2007-03-01 21:07:17 UTC
changed target
Comment 17 michael.ruess 2007-03-27 13:23:30 UTC
Verified in CWS chart2mst3.
Comment 18 michael.ruess 2007-06-21 15:34:40 UTC
Checked in 680m213.