Issue 56202

Created attachment 30603 [details]
patch

requires updated keysym stuff for `

Adding myself to CC

Hi Niklas,

please have a look at this one and set target according to the needs.

Frank

Default keyboard shortcuts are administered by User Experience, so I'm cc'ing
MMP to allow him to comment.
The new keysym defines are available now (since m152), but this all looks quite
unfinished.
- KEY_QUOTELEFT doesn't work on a German keyboard (probably others, too), so
alternative shortcuts have to be defined for the languages where it isn't available.
- KEY_QUOTELEFT doesn't show up in the configure dialog (which might be
considered correct, if it isn't always available).
- For the configure dialog, the new slot also needs a name.

As-is, this doesn't work. Is anybody working on it, or should we close the issue?

nn,
  will work on it. but could you tell me what are the 'requirements' (or
specifically problems?).

What I understand:
1. It needs a new slot in the configure dialog.

Thanks,
muthusuba

The slot name for the configure dialog is easy to add. It has to go into
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu.

But there are problems with using KEY_QUOTELEFT:
- It can't be used with some keyboard layouts, where "`" isn't a key of its own,
but reached via shift and another key.
- It isn't included in the "customize keyboard" dialog, which, as mentioned, may
be considered correct.

For the dialog, something has to be worked out with the framework team.

But it's incredible how much uncoordinated work has already gone into this
(including issue 56194) without first making sure that ctrl-` can even be used
at all.

nn,
  how is it done in excel (i have just seen the US keyboard, so i don't know)?

So, can i consider it as 
1. 'change the key ` to something else' 
2. 'make it configurable'?

Is just 2. (or 1.) enough or do we need both 1. and 2.

muthusuba

> But it's incredible how much uncoordinated work has already gone into
> this (including issue 56194) without first making sure that ctrl-` can
> even be used at all.

But wait - let me test - yes it works perfectly for me - so => it is usable.
i#56194 is confused because it uncovered an underlying screwup in vcl/uno
enumeration mapping (an inconsistent cut/paste code-duplication situation) -
which is indeed incredible ;-) Also, there is certainly no harm in having a more
complete set of key-mappings in VCL regardless of whether they are used in .de
locales.

Anyhow - as you say, fixing this hasn't been a priority for any of us - witness
the 6 month response time from fst's comment to yours ;-)

> - KEY_QUOTELEFT doesn't work on a German keyboard (probably others, too),
> so alternative shortcuts have to be defined for the languages where it
> isn't available.

So - this is an English-only keybinding initially - that is, unless you want to
tell us what Germans are familiar with using as a keybinding for this. 'Luckily'
the accelerator configuration is cut/pasted en-masse for each language - so
there is no need to have any German binding at all. Surely you can't block this
based on that ? [ also it would be presumably cheaper for the Help team to
change only 1 set of help ;-]

> - It isn't included in the "customize keyboard" dialog, which, as
> mentioned,  may be considered correct.

That is clearly a bug we should fix, thanks for the pointer there.

> incredible how much uncoordinated work has already gone into this

How do you suggest the work gets 'co-ordinated' ? and who is going to take
responsibility for actually making that happen ? I would love a good answer here.

Of course we are still awaiting a reply from 'MMP' - I'll assign the bug to him
so it's clearer we are waiting on him - 7 months seems a long time for no
comment from User Experience. I also change the milestone back to 2.x - it's no
solution to have patches lingering on outside the tree forever.

To muthusuba: Excel with a German keyboard uses shift-ctrl-', which one may
still call ctrl-`, but I don't know if they implemented it separately.

I use German WinXP and German Excel. On my PC-keyboard with Excel97 and on my
notebook with Excel 2002 it is Strg+<Key with has the number sign # and the
apostroph ' on it> (Strg=Ctrl). There is no shift needed.

ok, then i will add it as ctrl + ` and then provide an option to change this.

will adding code to
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu
(and related parts) be sufficient?

I would like the option in the 'customize' menu - pointers here will be helpful.

regina - cool; thanks - could you try configuring a keybinding in the binding
selector for this key [ for some other random function ;-], quitting and pasting
the change in the user-config XML for that ? on Linux that would be in:

~/.ooo-2.0/user/config/soffice.cfg/modules/scalc/accelerator/en-US/current.xml:

with a line like:
	<accel:item accel:code="KEY_Z" accel:mod1="true" xlink:href=".uno:Undo"/>

On win32 you may need to search for files called 'current.xml' to fetch that.
With that data, we can trivially add the German binding.

Thanks.

@mmeeks: No I cannot. There is no code for that key in
http://api.openoffice.org/docs/common/ref/com/sun/star/awt/Key.html
Does an undocumented code exist?

Created attachment 39987 [details]
Updated Patch with "Customize option"

We can now configure the key in the customize menu.

nn,
  Is this ok now? Please tell me in case you need more changes.
Thanx,
muthusuba

Is this going anywhere ? it seems uncontroversial to add a single keybinding for
a single language ? another 3 months passed with no approval / help merging /
leadership.

cd->mmeeks: I've just asked UX to think about a fast solution for the patch
(from my point of view to accept the it). I hope that we can end this discussion
soon.

Hi guys,
as far as I understand this issue, it is about
1) introducing a new shortcut: Ctrl+Apostrophe (in fact it is prime symbol
    http://en.wikipedia.org/wiki/Prime_%28symbol%29 and not the apostrophe
    http://en.wikipedia.org/wiki/Apostrophe
Question is whether it is ok to use characters for shortcuts that are only
available in plain version on certain language keyboards.
I would say yes. This is ok.

2) A new command should be introduced to change the formular view.
Can someone please add explain what is ment by this?

Fwd issue to Michael.

mmp: thanks :-) wrt. your point 2) the 'new command' is (I think) a pure
implementation detail; so we have all we need I think; thanks for the feedback.

mmeeks,
  since this is assigned to you, any updates on this? ;)

muthusuba

Hi Muthu - it looks like it's all approved: so can you create a CWS and check-it
in ? if not, we should prolly get you CVS access setup ? - following the steps
in the wiki for that would be a good plan I guess.

Accept.

committed to CWS msba01

deleted msba01 (since it was based on oof680)

will be fixed in msba02 (based on src680 (m212))

Grabbing issue to speed things up (see discussion in
http://sc.openoffice.org/servlets/ReadMsg?list=dev&msgNo=2326 and thread) in
order to get this into OOo2.3

Thanks a lot, er! 

@Muthu: please write a feature announcement using the EIS tool as described in
http://wiki.services.openoffice.org/wiki/Feature_announcement and mention that
this feature is available only on English keyboard layouts.
Don't forget to set your cws msba02 to deleted.

Merged from branch cws_src680_msba02 into cws dr55:

sc/inc/sc.hrc  1.53.32.5
sc/sdi/scalc.sdi  1.34.32.4
sc/sdi/tabvwsh.sdi  1.20.32.1
sc/source/ui/view/tabvwsh3.cxx  1.33.32.1
sc/source/ui/view/tabvwsha.cxx  1.20.52.1
sc/uiconfig/scalc/accelerator/en-US/default.xml  1.3.714.1
scp2/source/ooo/file_ooo.scp  1.192.14.4

Note that in inc/sc.hrc I changed
#define FID_TOGGLEFORMULA		(VIEW_MENU_START + 16)
to
#define FID_TOGGLEFORMULA		(VIEW_MENU_START + 10)
because of the // DANGER DIRTY ID for slot +16, probably identical IDs of Sfx
and Calc.

Note also that the accelerator file had to be added to scp2 to be included in
patch sets.

er,
  Sure.

We made the 'shortcut' configurable so as to make it work on non-English
keyboard layouts also.

muthusuba

er,
  done. please verify:
http://eis.services.openoffice.org/EIS2/changesmails.EditFeature?Id=3929

thanks,
muthusuba

Hi Muthu,

> We made the 'shortcut' configurable so as to make it work on
> non-English keyboard layouts also.

Sure, it is configurable, but in the default configuration it will not
be available on other keyboards.

> done. please verify:
> http://eis.services.openoffice.org/EIS2/changesmails.EditFeature?Id=3929

Should be sufficient and even lists the necessary flags, nice :-)
It's not translation relevant though, no strings added to resources or
menu files.

Thanks
  Eike

Reassigning to QA for verification.

How to change the key assignment:

Tools-Customize-Category View:
Select .uno:ToogleFormula 
Assign Key combination on the Shortcut Keys section and click on Modify Button.

Created attachment 46534 [details]
testcasespecification

*** Issue 79975 has been marked as a duplicate of this issue. ***

closed because fix available in src680_m225 (OOo 2.3)