Issue 60401

Keyword: ux-ctest

set target to OOo 2.x

Set target to OOo later.

This issue is important and listed on the quarterly review for Calc:
http://wiki.services.openoffice.org/wiki/2008_Q2_Review_of_Spreadsheet_Project
Therefore adjusting target to 3.x.

Accepted

Started

*** Issue 53134 has been marked as a duplicate of this issue. ***

Created attachment 57489 [details]
The specification.

Created attachment 57516 [details]
update the specification.

Created attachment 57519 [details]
The patch file is about i60401#-v1.

Created attachment 57563 [details]
The patch file is about i60401#-v2.

Created attachment 57564 [details]
The patch file is about i60401#-v2.

Created attachment 57568 [details]
The patch file is about i60401#-v3.

modify ID from (SC_DIALOGS_START + 145) to (SC_DIALOGS_START + 147)

Created attachment 57571 [details]
update the specification.

Created attachment 58110 [details]
The patch file is about i60401#-v4.

Created attachment 58131 [details]
Update the specification again.

Created attachment 58468 [details]
Update the patch.

The strings "A2:C4" and "B2:B4" in the dialog should be replaced by the actual
ranges (dynamically).

Created attachment 58492 [details]
Update the specification again.

Created attachment 58671 [details]
New version of the Sort Range dialog specification. Replaces "Sorting_StrategyDialog".

The question which range has to be applied when the user has selected more than
one single cell and cells next to the selection do also contain data, is not
only relevant for sorting.

Same situation is with AutoFilter, DataPilot, AutoFormat,...

Maybe we should not create a "Sort Range Dialog" but a more common "Range
Dialog". For the sake of consistency we should apply the same concept and
similar dialogs to all similar situations.

Created attachment 58927 [details]
Update the patch.

The selection of the new range looks good.

There's still the problem that pDocSh->GetDBData modifies the unnamed database
range (even if "cancel" is selected), and your new code is there three times
(should be merged together).

Created attachment 61272 [details]
Update the patch again.

Created attachment 61406 [details]
Update patch again.

I deleted some unuseful call for pDBData->SetArea(...) method in cellsh2.cxx.

I see one problem now: If the data range (say, B3:C6) has column headers, column
C is selected, and the "Extend selection" button pressed, the sort dialog
doesn't use column headers.

And I really suggest to move the new code - from "if( aSortParam.nCol1 !=
aSortParam.nCol2 )" to "ClearHighlightRanges" - into a helper function, instead
of having it 3 times.

Created attachment 61419 [details]
Update the patch again.

According to your suggestion,I have fixed it.

Created attachment 61466 [details]
Update the specification for Sort Range dialog again.

Created attachment 61594 [details]
Update the spec again.

Created attachment 61626 [details]
Update the patch again.

>Niklas
I used OOom45 version,the WordBreak can work well,I submitted a patch again.

taking the issue

I added the last patch, with some small changes to the dialog resource, to CWS
"dr68".

Created attachment 61747 [details]
Update the finial specification.

reassigning to QA for verification

Created attachment 63454 [details]
TestCaseSpecification

verified in internal build cws_dr68

Verified in DEV300m53 on WinXP.
Works very well
Closing

Reopening. Current implementation in OOO320_m6 and OOO300_m57 violates the
specification!

The specification reads:

"This document specifies a new dialog that will appear if the user invokes the
sort function when the selection contains more than one cell but some cells next
to the selection contain data."

And further:

"If the user selects a range of cells and then invokes the Sort button in the
toolbar or invokes the Data-Sort menu item, but there is data next to the
selected cells, then the user should be asked if s/he wants to sort only the
selected range, or the whole contiguous data range that contains the selection
and all the adjacent cells that contain data .  This is to prevent user errors
where a smaller range is sorted than the user thinks."

However, the current implementation shows the new dialog only if the user´s
selection inside a bigger contiguous range spans only one single column or one
single row. Thus, the specification is not fulfilled. Moreover, the current
implementation does *not* prevent user errors where a smaller range is sorted
than the user thinks, which is the main intention and the origin of the
specified feature.

Adding this issue as blocker of issue 99999 (Release stopper for OOo 3.2)

The origin of the issue was usability testing, where users selected the column
by which the range was to be sorted.

Special handling of single-column or row selection was mentioned on the list
(http://ux.openoffice.org/servlets/ReadMsg?list=discuss&msgNo=2640), and others
also do it that way, so I think the current behavior is intentional. The spec
should be updated then, or if there is consensus that the behavior isn't good,
it can be changed in a later version. But there's no need to treat this as a 3.2
stopper.

After discussion with nn in IRC we agreed that the implementation differs from
the spec. However, it still is a useful change that should be released with 3.2.

Please follow-up for further improvement with issue #107423.

closing.