Issue 61397

Summary:	Input sequence correction and checking should work in dialogs
Product:	gsl	Reporter:	jjc
Component:	code	Assignee:	stefan.baltzer
Status:	CLOSED FIXED	QA Contact:	issues@gsl <issues>
Severity:	Trivial
Priority:	P3	CC:	hin.stone, issues, markpeak, nesshof, samphan
Version:	OOo 2.0.1
Target Milestone:	OOo 2.0.3
Hardware:	All
OS:	All
Issue Type:	ENHANCEMENT	Latest Confirmation in:	---
Developer Difficulty:	---
Issue Depends on:
Issue Blocks:	41707

Description jjc 2006-01-31 03:17:26 UTC

Currently input sequence checking and correction work only in Writer. In
particular they do not work in dialogs.  To reproduce, type and invalid sequence
eg go gai, mai ek, mai ek (type "djj" on an US-English keyboard). On Windows,
you can tell that the invalid sequence has not been rejected because it takes
three backspaces to delete everything; on Unix, you can see from the display.

Issue 54913 is to implement input sequence checking and correction in
EditEngine, which will make them work in the other applications.  But making
them work in dialogs is apparently a separate job needing modification to
TextEngine in svtools and Edit in vcl (see comment to issue 54913).  This is
probably also related to issue 55937, which is to make cursor movement by
cluster work in dialogs.

Input sequence _correction_ in dialogs would be nice, but is not essential. 
Input sequence _checking_ is essential: normal Windows apps provide this
functionality.

Comment 1 stephan_schaefer 2006-02-03 13:57:38 UTC

reassign

Comment 2 hdu@apache.org 2006-02-13 12:22:02 UTC

reassigning

Comment 3 thomas.lange 2006-02-13 13:03:22 UTC

Comment 4 thomas.lange 2006-02-13 13:03:51 UTC

Comment 5 thomas.lange 2006-02-16 11:18:01 UTC

Done for Edit control.

Files changed:
vcl:
- edit.hxx
- edit.cxx
A sample control to test the implementation would be the "Replace" field in the
respective tab-page of "Tools / AutoCorrect".

Comment 6 thomas.lange 2006-02-16 11:19:20 UTC

The other class that needs to be changed is TextEngine.

Comment 7 thomas.lange 2006-02-20 08:56:22 UTC

Done for TextEngine.

Files changed:
- svtools/inc/texteng.hxx
- svtools/source/edit/texteng.cxx
- svtools/source/edit/textview.cxx

A sample view to test using the TextEngine would be the Writers HTML source view
or the
Basic IDE where you can write your Macros. Undo is working as well.
However since both of them have problems with displaying the characters properly
you have to paste the text to a differnt view e.g. a Writer text document to see
if all is correct. 

Note: I have already written issue 62208 to for the font problem.

Comment 8 thomas.lange 2006-03-01 10:30:42 UTC

For TextEngine testing one could also use "Comment" control in the "Description"
tab-page of the "File/Properties" dialog when a text document is opened.
This one does not show the problems when displaying the characters but it has no
"Undo" available in the UI.


re-open issue and reassign to sba@openoffice.org

Comment 9 thomas.lange 2006-03-01 10:30:48 UTC

reassign to sba@openoffice.org

Comment 10 thomas.lange 2006-03-01 10:30:54 UTC

reset resolution to FIXED

Comment 11 stefan.baltzer 2006-03-13 11:30:00 UTC

SBA: Verified in CWS tl19.

Comment 12 stefan.baltzer 2006-07-04 11:18:12 UTC

SBA: Closed.