Issue 69602

Summary:	obo05: VSE build breaks in shell
Product:	Build Tools	Reporter:	quetschke
Component:	code	Assignee:	oliver.bolte
Status:	CLOSED FIXED	QA Contact:	issues@tools <issues>
Severity:	Trivial
Priority:	P2	CC:	issues
Version:	current
Target Milestone:	OOo 2.1
Hardware:	PC
OS:	Windows, all
Issue Type:	DEFECT	Latest Confirmation in:	---
Developer Difficulty:	---

Description quetschke 2006-09-17 07:25:08 UTC

The build breaks with:

Making: ../../../../wntmsci11.pro/res/shlxthdl.res
guw.pl rc -I.  -I../../../../wntmsci11.pro/inc/shlxthdl -I../inc
-I../../../../inc/pch -I../../../../inc -I../../../../WIN/inc
-I../../../../wntmsci11.pro/inc -I.
-I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/inc/stl
-I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/inc/external
-I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/inc
-I/cygdrive/d/w1/tin_obo05/solenv/wntmsci11/inc
-I/cygdrive/d/w1/tin_obo05/solenv/inc -I/cygdrive/d/w1/tin_obo05/res
-I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/inc/stl
-I/cygdrive/c/J2SDK1~1.2_0/include/win32 -I/cygdrive/c/J2SDK1~1.2_0/include
-I/cygdrive/c/PROGRA~1/MICROS~4/include
-I/cygdrive/c/PROGRA~1/MID05A~1/VC/include
-I/cygdrive/c/PROGRA~1/MICROS~1.0SD/include    
-I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/inc/offuh -I.
-I../../../../res -I. -I/cygdrive/d/w1/tin_obo05/solver/680/wntmsci11.pro/res
-I/cygdrive/c/PROGRA~1/MICROS~4/include/atl
-I/cygdrive/c/PROGRA~1/MID05A~1/VC/PlatformSDK/include/mfc  -r -DWIN32
-fo../../../../wntmsci11.pro/res/shlxthdl.res
../../../../wntmsci11.pro/res/shlxthdl.rc 
..\..\..\..\wntmsci11.pro\res\shlxthdl.rc(1) : fatal error RC1015: cannot open
include file 'winres.h'.

dmake:  Error code 1, while making '../../../../wntmsci11.pro/res/shlxthdl.res'
---* tg_merge.mk *---

ERROR: Error 65280 occurred while making
/cygdrive/d/w1/tin_obo05/shell/source/win32/shlxthandler/res


I'm currently trying this patch:

@@ -357,8 +367,13 @@
 
 ATL_INCLUDE*=$(COMPATH)$/PlatformSDK$/include$/atl
 ATL_LIB*=$(COMPATH)$/atlmfc$/lib
-MFC_INCLUDE*=$(COMPATH)$/PlatformSDK$/include$/mfc
+.IF "$(NETTOOLKIT)" != ""
+MFC_INCLUDE*=$(PSDK_HOME)$/Include$/mfc
 MFC_LIB*=$(COMPATH)$/atlmfc$/lib
+.ELSE
+MFC_INCLUDE*=$(COMPATH)$/PlatformSDK$/include$/mfc
+MFC_LIB*=$(PSDK_HOME)$/lib
+.ENDIF
 
 LIBMGR=$(WRAPCMD) lib $(NOLOGO)
 IMPLIB=$(WRAPCMD) lib


and this cures the shell module, but if anything from
 $(COMPATH)$/atlmfc$/lib
from the "real" VS is needed this will fail as those libs are not included
in the express version.

Comment 1 quetschke 2006-09-18 04:41:56 UTC

I moved the MFC_INCLUDE/MFC_LIB into set_soenv.in (issue 69539) and surprisingly
the build finished. (Except the embedserv problem.)

Comment 2 oliver.bolte 2006-09-19 12:25:34 UTC

I've commited shell/source/win32/shlxthandler/res/makefile.mk with
+ INCPRE+=$(MFC_INCLUDE) (MFC_INCLUDE is set in ssrc680.ini) it was locally
modified on my cws :-(

Comment 3 quetschke 2006-09-19 13:52:26 UTC

But it already worked for me after my set_soenv.in (OOo only) change?

Comment 4 oliver.bolte 2006-09-19 14:08:28 UTC

Yes, it was a fix related to SO build environment.

Comment 5 oliver.bolte 2006-09-22 13:45:16 UTC

verified.

Comment 6 oliver.bolte 2006-09-29 14:21:51 UTC

closed.