Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | unhelpful string constructors ... | ||
---|---|---|---|
Product: | utilities | Reporter: | mmeeks <mmeeks> |
Component: | code | Assignee: | AOO issues mailing list <issues> |
Status: | ACCEPTED --- | QA Contact: | issues@tools <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues, kay.ramme, malte_timmermann |
Version: | 680m189 | ||
Target Milestone: | OOo 3.x | ||
Hardware: | All | ||
OS: | Linux, all | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
mmeeks
2006-10-23 17:37:31 UTC
taken over I would suggest to just drop UniString( const sal_Char* pByteStr, rtl_TextEncoding eTextEncoding, sal_uInt32 nCvtFlags = BYTESTRING_TO_UNISTRING_CVTFLAGS); and only keep UniString( const sal_Char* pByteStr, xub_StrLen nLen, rtl_TextEncoding eTextEncoding, sal_uInt32 nCvtFlags = BYTESTRING_TO_UNISTRING_CVTFLAGS); and do an incompatible cleanup from tools upwards. (ByteString, rtl::OUString, rtl::OString seem to not have any equally problematic functions, by the way.) @kr,mt: Are you planning on any tools string changes, anyway? Otherwise, I would suggest we do this on a OOo 2.x target (I assume there are not too many occurrences of that constructor). It appears that issue 70166 will introduce some code to work around consequences of this issue. That work-around code should be removed once this issue is fixed. Removing the c'tor looks fine for me! Valid uses of the to-be-dropped ctor String(p, enc[, flags]) can be replaced with String(p, STRING_LEN, enc[, flags]) see tools/source/string/strucvt.cxx:1.10 l. 115--116. according to release status meeting -> target 3.x Reset assigne to the default "issues@openoffice.apache.org". |