Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Description
sdietrich
2002-08-20 23:01:52 UTC
This problem is also evident in linux (running RedHat 7.2). Steps: 1. in shell, export LC_ALL="baltic" 2. Open swriter 3. Open "Tools->Options..." window 4. Expand "Load/Save" 5. Click on "HTML Compatability" 6. Crash Hi, in the porting project (dev@porting) there was a long discussion about this problem and several porters contributed their input. I think, Oliver is the maintainer of this code (nlsupport.c). Oliver, could you help here? I can't do anything about this: there will always be textencodings we don't have mappings for. on the other hand, the office should not crash because of this. So this should definitly be fixed in the SvxTextEncodingBox, which feeds rtl_getTextEncodingFromMimeCharset with a NULL pointer here. Eike, are you the actual owner of this code ? Hi, Eike is on vacation this week. Don't expect his feedback before beginning of next week. accepted Eike, Can you reassign to me? I've got patches that correct this problem and correctly implement locale support on MacOS X and Darwin. They will be going into our X11 beta in a week and I'm just cleaning them up now... Dan Attached patch from 10/01/02 implements MacOS X/Darwin nlsupport. It uses the system call CFStringGetSystemEncoding() from CoreFoundation to return the current system text encoding, and translates that encoding into an RTL text encoding. We use the _pair_search() and other routines to search through the lookup tables to find the RTL text encoding. We also use some of the Linux _nl_language_list structure for searching as well, and supplement that with a MacOS X/Darwin specific list. On MacOS X (well, the Quartz/Aqua port really) we use a CoreFoundation call to return the IANA charset encoding name which then gets looked up in our tables, but on Darwin this call doesn't exist so we implement it manually with a big switch{}. This patch corrects all known text-encoding-related crashes and freezes, including the HTML Compatibility crash. Cheers, Dan Created attachment 3035 [details]
cd SRC_ROOT/sal, patch -p0 < /path/to/patchfile, rebuild sal
Request approval for this patch for commission to OOO_STABLE_1_PORTS and others. Please add keyword "approval_pending". ----- PLEASE VERIFY SAFENESS ON OTHER PLATFORMS ----- Dan @Dan: reassigning to you as requested Created attachment 3054 [details] Implements locale retrieving using Java (for experimentation only). Includes previous patch and sal patches in issue 7458. Apply to clean checkout of sal using the following commands: cd $SRC_ROOT/sal ; patch -p0 < /path/to/patch/file Created attachment 3066 [details]
Adds JavaVM framework to static linking of tools. Apply this patch to a clean checkout of the tools module using the following commands: cd $SRC_ROOT/tools ; patch -p0 < /path/to/patch/file
reassigning to me :) Fine, take it. I never really wanted it anyway :) Seriously, I'm looking at CFPreferences methods of implementing non-Java locale discovery. Using the "AppleLanguages" preference value we can pull out the preferred language. Suggestion from Greg Parker. Anyway, use this issue to implement Patrick's locale method, and I'll file a new one for conversion to CFPreferences and track those changes there. Dan Oh dude...I never mean to imply i was taking it to fix it ;) I just went through and assigned bugs to me to help me out in keeping track of all of them without resoring to figuring out IZ's query stuff. You can have it back if you want. The CFPreferences stuff does sound like a better approach...I really feel we shouldn't need Java to do locale detection. Thankfully Java is integrated nicely with OS X so it's not as big of an issue like on other platforms :) Nah, I was just joking. This issue should get approved, committed, and closed. We can open another one to take care of further improvements (ie locale detection w/o Java). That will take a bit of time however. Dan Created attachment 3677 [details]
cd to SRC_ROOT/sal, patch -p0 < /path/to/patchfile
Ed/Kevin, Can you guys sign off on the 111902 sal patch? If so I'll commit to OOO_STABLE_1_PORTS. Patch adds: 1) Dan Williams/Patrick Luby locale support 2) 10.2 building support with getpwnam_r() Dan NOTE: tools patch should not be approved yet, on the sal 111902 patch. Ah hell, approve the tools 100502 patch while you're at it too, it adds 3 MacOS X specific lines. Dan Hi, Completely MacOSX specific. Looks good, Approved. Kevin Hi, I should have saiod both are approved. Kevin sal.OOO_STABLE_1_PORTS.111902.patch tools.OOO_STABLE_1_PORTS.100502.patch Committed to OOO_STABLE_1_PORTS. Removed keyword approval_pending Added keywork merge_pending Dan Tracking more up-to-date changes to this issue over in Issue 8361 Fixed in ports. close issue. |