|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Convert into bmp does not change to picture bar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Draw | Reporter: | wolframgarten | ||||||
| Component: | ui | Assignee: | wolframgarten | ||||||
| Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> | ||||||
| Severity: | Trivial | ||||||||
| Priority: | P3 | CC: | Armin.Le.Grand, clippka, issues, rbircher, weike.liang | ||||||
| Version: | 680m199 | ||||||||
| Target Milestone: | OOo 3.2 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Issue Depends on: | |||||||||
| Issue Blocks: | 72764 | ||||||||
| Attachments: |
|
||||||||
|
Description
wolframgarten
2007-01-25 15:01:27 UTC
Summary adapted. Retargeted to OOo 2.4. Retargeted to 2.x due to time constraints. set target from 2.x to 3.x according http://wiki.services.openoffice.org/wiki/Target_3x Created attachment 49755 [details]
The old object should not be marked when the new object is marked.
While the rectangle is converted into bmp the new graphics of bmp will replace the rectangle. But, during the procedure the both objects are marked and put into the list of marked objects at the same time. And this leads to the result that the returned context is SDRCONTEXT_STANDARD rather than SDRCONTEXT_GRAPHIC, which can be seen in the method "SdrView::GetContext()". Therefore we just need to make the old object unmarked to avoid the case. Fixed by liangweike Please verify. Verified in CWS as a stand-in for cgu. Created attachment 51741 [details] The new patch is created because the old one leads to issue84984. Reopening issue as preparation for migration to cws impress164. . Reapplied fix in cws impress164. Svn revisions are 264133 and 264134. Changing target to OOo 3.2. @wg: Please verify. just for the record, the given patch breaks other features, namely all features that sequentially replace mared objects. for example draw to rectangles, select both and select combine, impress crashes! For now I removed the code from the svdmarkv.cxx and added a if( IsObjMarked( pOldObj ) ) MarkObj( pOldObj, &rPV, TRUE /*unmark!*/ ); to SdrEditView::ReplaceObjectAtView In the future we should change all operations on the mark list to use a copy of the mark list and not the living mark list Verified in CWS. AW: Some more info: I already isolated wite access to SdrMarkList at SdrMarkView by making GetMarkedObjectListWriteAccess() private and the only way to access the local selection list, all usages are adapted. Before that, everyone could change it as wanted, with unpredictable results. In the long run, one of the next big redesigns should be the controller level (View, Selections and Interactions). HTH! fixed in master closing issue |