Issue 79087

Summary: API: several UNO-API tests fails in chart2
Product: App Dev Reporter: chne
Component: apiAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact:
Severity: Trivial    
Priority: P3 CC: issues
Version: 3.3.0 or older (OOo)   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: TASK Latest Confirmation in: ---
Developer Difficulty: ---

Description chne 2007-07-02 14:32:44 UTC
Since chart2 several UNO-API tests fails:

sch.ChXChartDocument::com::sun::star::chart::ChartTableAddressSupplier
sch.ChXChartDocument::com::sun::star::chart::ChartTableAddressSupplier
sch.ChXChartDocument::com::sun::star::chart::XChartDocument
sch.ChXChartDocument::com::sun::star::frame::XModel
sch.ChXChartDocument::com::sun::star::lang::XComponent
sch.ChXChartView::com::sun::star::view::XSelectionSupplier
sch.ChXDataPoint::com::sun::star::beans::XPropertySet
sch.ChXDataPoint::com::sun::star::chart::Chart3DBarProperties
sch.ChXDataPoint::com::sun::star::chart::ChartDataPointProperties
sch.ChXDataPoint::com::sun::star::drawing::LineProperties
sch.ChXDataPoint::com::sun::star::style::CharacterProperties
sch.ChXDataRow::com::sun::star::beans::XPropertySet
sch.ChXDataRow::com::sun::star::chart::Chart3DBarProperties
sch.ChXDataRow::com::sun::star::chart::ChartDataPointProperties
sch.ChXDataRow::com::sun::star::chart::ChartDataRowProperties
sch.ChXDataRow::com::sun::star::drawing::FillProperties
sch.ChXDataRow::com::sun::star::drawing::LineProperties
sch.ChXDataRow::com::sun::star::style::CharacterProperties
sch.ChXDataRow::com::sun::star::xml::UserDefinedAttributeSupplier
sch.ChXDiagram::com::sun::star::chart::ChartAxisXSupplier
sch.ChXDiagram::com::sun::star::chart::ChartAxisYSupplier
sch.ChXDiagram::com::sun::star::chart::ChartAxisZSupplier
sch.ChXDiagram::com::sun::star::chart::LineDiagram
sch.ChXDiagram::com::sun::star::chart::StockDiagram
sch.ChXDiagram::com::sun::star::drawing::XShape
sch.ChXDiagram::com::sun::star::xml::UserDefinedAttributeSupplier
Comment 1 chne 2007-07-03 19:53:16 UTC
also affected:
xmloff.Chart.XMLExporter
xmloff.Chart.XMLContentExporter
Comment 2 bjoern.milcke 2007-07-09 12:20:14 UTC
ChXChartDocument: service ChartTableAddressSupplier fails. Reason: it is no
longer supported, it was optional (not even mentioned in the API documentation)
and only a temporary solution which is now replaced by range properties at the
chart objects.

->CN: Please remove this test from ChXChartDocumet.java, and maybe also the
interface test.
Comment 3 bjoern.milcke 2007-07-09 12:45:08 UTC
Interface test XChartDocument fails in setDiagram, because old and new type is
the same (both pie).

->CN: Please check if the test is correct. In the old chart the XDiagram was no
real interface. an ChXChartDocument::createInstance( "<diagram service>" )
already changed the chart type, setDiagram only changed the chart type again, in
this case did probably nothing.

It should work like this:
1. getDiagram() -> getType() -> old type
2. create a diagram via factory (pie)
3. setDiagram() -> getDiagram() (!important to retrieve the new diagram again,
the old XDiagram is still the old type) -> getType() -> new type

It should even work when 1. and 2. are interchanged.
Comment 4 bjoern.milcke 2007-07-09 14:45:09 UTC
changing to TASK.
Comment 5 bjoern.milcke 2007-07-09 15:57:11 UTC
->CN: In ifc/chart/_Chart3DBarProperties.java please use a different
XPropertySet object to set the "Dim3D" property at the diagram. Currently, oObj
is used, which overwrites the XPropertySet of the ChXDataPoint test.

Patch:

Index: _Chart3DBarProperties.java
===================================================================
RCS file: /cvs/qa/qadevOOo/tests/java/ifc/chart/_Chart3DBarProperties.java,v
retrieving revision 1.3
diff -c -r1.3 _Chart3DBarProperties.java
*** _Chart3DBarProperties.java  8 Sep 2005 23:08:23 -0000       1.3
--- _Chart3DBarProperties.java  9 Jul 2007 14:56:12 -0000
***************
*** 79,88 ****

          doc.setDiagram(bar);
          log.println("Change Diagram to 3D");
!         oObj = (XPropertySet)
              UnoRuntime.queryInterface( XPropertySet.class, doc.getDiagram() );
          try {
!             oObj.setPropertyValue("Dim3D", new Boolean(true));
          } catch(com.sun.star.lang.WrappedTargetException e) {
              log.println("Couldn't change Diagram to 3D");
              e.printStackTrace(log);
--- 79,88 ----

          doc.setDiagram(bar);
          log.println("Change Diagram to 3D");
!         XPropertySet oDiaProp = (XPropertySet)
              UnoRuntime.queryInterface( XPropertySet.class, doc.getDiagram() );
          try {
!             oDiaProp.setPropertyValue("Dim3D", new Boolean(true));
          } catch(com.sun.star.lang.WrappedTargetException e) {
              log.println("Couldn't change Diagram to 3D");
              e.printStackTrace(log);
Comment 6 bjoern.milcke 2007-07-09 23:04:57 UTC
->CN: Two things concerning ChXChartDocument::frame::XModel

1. Please change the relation "TOSELECT" to something different. We no longer
have a main title per default. Either insert a main title before, or change the
object to getArea() or getLegend()

2. XSelectionSupplier no longer works with objects but instead with
object-identifier strings. To get the object of the current selection there is
the method XModel::getCurrentSelection() which doesn't work, as selection is
done with XSelectionSupplier::select( XInterface object ) Use "CID/Page=" for
selection the Area.
Comment 7 bjoern.milcke 2007-07-16 16:42:51 UTC
Issue is in progress, but won't be complete for 2.3.
Comment 8 bjoern.milcke 2008-01-16 13:35:23 UTC
still ongoing ...
Comment 9 bjoern.milcke 2008-06-04 20:36:27 UTC
Changing target due to lack of resources.
Comment 10 IngridvdM 2008-07-03 11:48:55 UTC
change owner