Issue 80067

Summary: warning: comparison with string literal in binfilters
Product: General Reporter: pmladek <pmladek>
Component: codeAssignee: christian.guenther
Status: CLOSED FIXED QA Contact: issues@framework <issues>
Severity: Trivial    
Priority: P3 CC: andreas.schluens, issues, kendy
Version: 680m222Keywords: regression
Target Milestone: OOo 2.3   
Hardware: PC   
OS: Linux, all   
Issue Type: PATCH Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 80294    
Attachments:
Description Flags
Proposed fix.
none
Impress 5.0 sample document none

Description pmladek 2007-07-26 12:22:19 UTC 
I have got the following warnings in the binfilter module in src680_m222:

--- cut ---
/usr/src/packages/BUILD/ooo-build-src680-m221d/build/src680-m222/binfilter/bf_svx/source/svdraw/svx_svdobj.cxx:2892:
warning: comparison with string literal results in unspecified behaviour
/usr/src/packages/BUILD/ooo-build-src680-m221d/build/src680-m222/binfilter/bf_svx/source/svdraw/svx_svdobj.cxx:2892:
warning: comparison with string literal results in unspecified behaviour
--- cut ---

The code is really broken. I'll attach a possible fix. I am not sure if the test
for NULL pointer is needed but it seems so...
Comment 1 pmladek 2007-07-26 12:23:38 UTC 
Created attachment 47105 [details]
Proposed fix.
Comment 2 Olaf Felka 2007-07-26 15:28:06 UTC 
@ as: Something from your playground?
Comment 3 Mathias_Bauer 2007-08-20 09:01:18 UTC 
The NULL pointer test isn't necessary but it doesn't hurt. :-)
Thanks for the patch. As this is a regression I will try to get it fixed in 2.3.
Comment 4 Mathias_Bauer 2007-08-21 14:01:06 UTC 
Created attachment 47678 [details]
Impress 5.0 sample document
Comment 5 Mathias_Bauer 2007-08-21 14:01:27 UTC 
As the wrong string comparison damaged an old fix for an old problem I attached
the original sample document that now is imported wrongly.
Load the attached document and go to the slide "architektur". You will recognize
at least one wrongly positioned element immediately. The fix should correct that.
Comment 6 Mathias_Bauer 2007-08-21 14:04:54 UTC 
added keyword "regression"
Comment 7 Mathias_Bauer 2007-08-21 14:05:17 UTC 
please verify
Comment 8 christian.guenther 2007-08-21 15:24:23 UTC 
CGU: Verified in cws binfilterregression.
Comment 9 christian.guenther 2007-09-20 10:40:49 UTC 
CGU: Integrated in src680m228 and oog680m5