Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing
|Summary:||Page format limited to 300 mm|
|Status:||CLOSED FIXED||QA Contact:||issues@graphics <issues>|
|Priority:||P2||CC:||Armin.Le.Grand, issues, jnavrati, kpalagin, philipp.lohmann, rainerbielefeld_ooo_qa|
|Target Milestone:||OOo 3.0|
|Issue Type:||PATCH||Latest Confirmation in:||---|
Description jirkaz 2007-09-21 09:22:57 UTC
Draw from OOo2.3CZ on WXP: I can't set page size bigger than 300x300 mm. If i try set e.g. A3, this format is changed to "User" and the bigger dimension (here 420 mm) is limited up to 300 mm... Tested also in Draw from OOo2.2.1CZ - all is OK. I can't believe that 2.3 version is rated as final - I found two basic problems (this and #81708) which are unacceptable for common use. Developers - isn't some deleterious MS agent among you?
Comment 1 jnavrati 2007-09-21 10:50:49 UTC
I can confirm this issue to be reproducible in m226 as well. The maximum values for page width/height are set to 300 centimeters. If you change units to centimeters (or other units), you can set width or height up to 300. I don't know now, where OOo ignores currently set unit system. Or perhaps there is error in parsing an edit field. I will do more investigating.
Comment 2 jnavrati 2007-09-25 15:25:30 UTC
*** Issue 81883 has been marked as a duplicate of this issue. ***
Comment 3 jnavrati 2007-09-25 15:27:33 UTC
There is some bug in units conversion. Reassign to myself and will keep working on it.
Comment 4 jumbo444 2007-09-28 14:48:49 UTC
Hello, It seems that the maximum width or hight is 300 whatever unit is (mm, cm, pica, km, in...). So, for A3 size in mm it is problematic.
Comment 6 jnavrati 2007-10-04 14:26:52 UTC
I've uploaded patch that fix the main problem. Maximum width/height size was set in "undefined" format, that's why comparison with a current field value doesn't work properly. I've changed a maximum paper width/height value to 300 cm. This value is then converted according to field's unit. Now, it is possible to set a paper size up to 300cm, doesn't matter which unit are currently used. Further, there are some minor issues which should be fixed as well: - margin's max value is 99999 "unknown" units -> fix could be similar as with paper width/height - size in points could be set with a decimal value, e.g. 768,12pt. Is this ever possible ?
Comment 7 Rainer Bielefeld 2007-10-14 10:00:01 UTC
*** Issue 82590 has been marked as a duplicate of this issue. ***
Comment 8 christian.guenther 2007-10-15 17:00:43 UTC
set aw to cc
Comment 9 Armin Le Grand 2007-10-23 10:56:27 UTC
AW: Adding PL to CC. AW->PL: The patch touches VCL Control, please have a look if this is acceptable. Thanks.
Comment 10 philipp.lohmann 2007-10-23 11:16:44 UTC
I think the Control part of the patch is wrong; the normalization is done by the ConvertValue method (the digit parameter is for that). This ought to be right since normalization/denormalization is responsibility of the NumericFormatter, not the MetricFormatter.
Comment 11 Armin Le Grand 2007-10-23 11:28:03 UTC
AW->PL: So do You have a suggestion how to do it right?
Comment 12 philipp.lohmann 2007-10-23 11:40:08 UTC
I don't think it was wrong before. Just skip that part of the patch.
Comment 13 Armin Le Grand 2007-10-23 11:43:06 UTC
AW->PL: Please give somemore hints. Should i skip the vcl/source/control/field.cxx parts completely? Only one call of it? Two? Which ones? Are You sure the patch will work without those?
Comment 14 philipp.lohmann 2007-10-23 11:46:12 UTC
pl->aw: Yes, you should not touch vcl/source/control/field.cxx. No, I don't know what that does to the rest of the patch, but I don't think the modifications in field.cxx are correct.
Comment 15 Armin Le Grand 2007-10-23 12:24:49 UTC
AW->jnavrati: Please see comments above. Please check if Your patch works without the changes in Contol. If not, let us know.
Comment 16 philipp.lohmann 2007-10-23 12:32:32 UTC
pl->jnavrati: I think instead of aPaperWidthEdit.SetMax(aDrawinglayerOpt.GetMaximumPaperWidth(), FUNIT_CM); you should do aPaperWidthEdit.SetMax( aPaperWidthEdit.Normalize( aDrawinglayerOpt.GetMaximumPaperWidth() ), FUNIT_CM); The Min/Max values of the field are in the same range as the values, that is with 10^(GetDecimalDidgets())
Comment 17 jnavrati 2007-10-23 13:36:14 UTC
Hi guys, thank you for your comments. I wasn't sure from the beginning if the patch is correct or not, because I felt changing field.cxx wasn't a good step. I'm very happy for your comments and suggestions. I think that the last pl's modification should work as well and we don't have to touch field.cxx at all. I'll try this asap and send the results.
Comment 18 jnavrati 2007-10-24 10:58:47 UTC
Good news, it works in the same way without changes in Control. Thanks to pl. Bad news, I see some other suspicious behaviour in this case that regards units conversation generally. e.g. changing page format from "Screen" to "A4" gives page size 296.99mmx209.99mm that is not very nic. And changing back to "Screen" shows 280.00mmx209.99mm. I will try to do more investigating in this area, but I think that there are lots of ways how to set metric values and a mixture of these methods causes the problems. imho it would be fine to do it one way.
Comment 19 christian.guenther 2007-11-06 10:48:52 UTC
*** Issue 83350 has been marked as a duplicate of this issue. ***
Comment 20 Armin Le Grand 2007-11-09 09:45:18 UTC
AW->jnavrati: Probably a numerical problem since all that stuff uses integers for calculation. Is Your current solution good enough to go with it or do You think it's better/necessary to hunt that numerical problem and solve it?
Comment 21 jnavrati 2007-11-12 10:03:48 UTC
->AW: I'd rather fix it completely. But question is, if we either accept this patch that doesn't work correctly in some ways (i.e. gives a strange numbers), but that fixes the primary issue (i.e. page format). Or if we do more investigation to solve the problem that will probably take longer. From my point of few, as a user, I would be happy if all the stuff worked fine. Instead of complaining of a wrong numbers and logging more similar issues.
Comment 22 Armin Le Grand 2007-12-06 10:26:34 UTC
*** Issue 81665 has been marked as a duplicate of this issue. ***
Comment 23 Joe Smith 2007-12-06 15:21:20 UTC
Although this is a serious regression, the workaround is so easy and effective that I (at least) would vote for a higher-quality fix that may take a little longer, over a quick fix that leads to more problems.
Comment 24 jirkaz 2007-12-12 11:44:08 UTC
I can't understand the principle of this problem.... In 2.2.1 and earlier versions of OOo was the page format without any problem - why don't you go back to the old good solution?
Comment 25 kpalagin 2008-01-08 09:19:58 UTC
*** Issue 84775 has been marked as a duplicate of this issue. ***
Comment 27 jnavrati 2008-01-11 10:13:48 UTC
I attached an updated patch that fix a issue about maximum page size. Now, I can set the page size up to 300cm. Please, verify.
Comment 28 Rainer Bielefeld 2008-01-15 14:18:07 UTC
*** Issue 85259 has been marked as a duplicate of this issue. ***
Comment 29 Rainer Bielefeld 2008-01-15 14:24:38 UTC
Unfortunately this problem also exists for CALC and WRITER. "Blocks" and "DUP" seems to be a little excessive
Comment 30 jnavrati 2008-01-17 12:57:17 UTC
->aw: What do you thing about my latest patch? I can confirm it fixes the page format limits and it works for me fine.
Comment 31 Armin Le Grand 2008-01-17 15:09:58 UTC
AW->jnavrati: I took a short look at the code, will look the next days (when i have a fresh BugFixing CWS) and check functionality. I'll keep You informed. AW->PL: What do You think?
Comment 32 Armin Le Grand 2008-02-12 12:48:50 UTC
AW: Added to CWS aw055 (BugFixing for 3.0) and tesing now. Adding needed modules (svx, svtools, officecfg). Will apply patch and test...
Comment 33 Armin Le Grand 2008-02-12 14:16:58 UTC
AW: Checked on m245, looks very good. Checked in. AW->jnavrati: Thanks! Works wery well! Patch added and accepted.
Comment 34 Armin Le Grand 2008-02-12 14:19:05 UTC
AW: Oops, setting target...
Comment 35 Armin Le Grand 2008-04-09 03:09:12 UTC
AW->CGU: Please verify. Follow the first example. You need to change units to mm in extras/options first.
Comment 36 Armin Le Grand 2008-04-09 09:58:53 UTC
*** Issue 88062 has been marked as a duplicate of this issue. ***
Comment 37 christian.guenther 2008-04-18 14:04:17 UTC
CGU: Verified in cws aw055
Comment 38 christian.guenther 2008-06-24 18:44:14 UTC
CGU: integrated in dev300m19