Issue 82551

retarget

accepted

this issue has been fixed now

sj->clu: You can test the bugfix by adding the component via unopkg.

verified in cws

I have no idea how you verified this, but (m236 build):

rene@frodo:~/OpenOffice.org/SRC680/sdext$ sudo
/opt/openoffice.org2.3/program/unopkg add --shared
unxlngx6.pro/bin/sun-presentation-minimizer.oxt 

ERROR: Could not obtain the url to the license text file.
       Cause: Cannot find a localized license text or a default license text.

unopkg failed.

Reopen.

reassign

I see this issue is partly fixed, the problem is that the default language
doesn't work. If a locale is used that doesn't match to a license text, the
unopkg add fails.

are you sure?

rene@frodo:~/OpenOffice.org/SRC680/sdext/unxlngx6.pro/bin$ LANG="en_NZ" sudo
/opt/openoffice.org2.3/program/unopkg add --shared sun-presentation-minimizer.oxt 

ERROR: Could not obtain the url to the license text file.
       Cause: Cannot find a localized license text or a default license text.

unopkg failed.

Yes, it seems that without an "license-id" attribute no default is taken (and in
my opinion this is a bit redundant)

http://api.openoffice.org/docs/DevelopersGuide/Extensions/Extensions.xhtml#1_5_description.xml

sj: this now has been fixed in cws[pppopt04]

the fix takes place in solenv/bin/licinserter.pl 1.2.50.1
and sdext/source/minimizer/description.xml 1.4.4.1

reopening.

solenv and sdext from cws pppopt04 give the same.

@rene, then please add your description.xml as attachment, so that I can see
that anything has been build correct.

rene@frodo:~/OpenOffice.org/SRC680/solenv$ cat CVS/Tag 
Tcws_src680_pppopt04
rene@frodo:~/OpenOffice.org/SRC680/solenv$ cd ../sdext
rene@frodo:~/OpenOffice.org/SRC680/sdext$ cat CVS/Tag 
Tcws_src680_pppopt04
rene@frodo:~/OpenOffice.org/SRC680/sdext$ cat
./unxlngx6.pro/misc/SunPresentationMinimizer/description.xml
<?xml version="1.0" encoding="UTF-8"?>
<description xmlns="http://openoffice.org/extensions/description/2006"
        xmlns:dep="http://openoffice.org/extensions/description/2006"
    xmlns:xlink="http://www.w3.org/1999/xlink">
        <version value="1.0" />
        <dependencies>
                <OpenOffice.org-minimal-version value="2.3"
dep:name="OpenOffice.org 2.3"/>
        </dependencies>
        <registration>
        <simple-license accept-by="admin" default-license-id="lic-en-US">
        </simple-license>
    </registration>
</description>

@rene, I can see in your posted description.xml that you are using the correct
version and that my fixes are working properly: default-license-id has been
changed from "en-NZ" to "lic-en-US" -> my fix works as desired the
description.xml is no longer broken.

---------------------------------

I can also see in your description.xml that your license texts are still
missing, but this can|t be fixed by me. You might have one of the following
problems:

Maybe the following code of the makefile.mk isn|t copy at least one license text
(the licenses are used from the osl project) :
.IF "$(GUI)" == "WIN" || "$(GUI)" == "WNT"
$(PACKLICS) : $(SOLARBINDIR)$/osl$/license$$(@:b:s/_/./:e:s/./_/)$$(@:e).txt
	@@-$(MKDIRHIER) $(@:d)
	$(GNUCOPY) $< $@
.ELSE
$(PACKLICS) : $(SOLARBINDIR)$/osl$/LICENSE$$(@:b:s/_/./:e:s/./_/)$$(@:e)
	@@-$(MKDIRHIER) $(@:d)
	$(GNUCOPY) $< $@
.ENDIF

or second, the licinserter.pl is not working properly, this perl script makes
one entry in description.xml for each license text.

At the end, the description.xml file should look similar to this:

<?xml version="1.0" encoding="UTF-8"?>
<description xmlns="http://openoffice.org/extensions/description/2006"
	xmlns:dep="http://openoffice.org/extensions/description/2006"
    xmlns:xlink="http://www.w3.org/1999/xlink">
	<version value="1.0" />
	<dependencies>
		<OpenOffice.org-minimal-version value="2.3" dep:name="OpenOffice.org 2.3"/>
	</dependencies>
	<registration>
        <simple-license accept-by="admin" default-license-id="lic-en-US">
            <license-text xlink:href="registry/LICENSE_en-US" lang="en-US"
license-id="lic-en-US"/>
            <license-text xlink:href="registry/LICENSE_de" lang="de"
license-id="lic-de"/>
        </simple-license>
    </registration>
</description>


Please provide another Issue for your problem.

still verified because I didn|t touch any code.

sj: sorry, I don't believe that this is relevant in any case.

a) this is a build with en-US only, so of course no de license stuff there
b) I did a clean build, with readlicense_oo etc. built (you missed a build dep
on that one), there's no osl project but readlicense_oo.
c) the description.xml as created by a plain en-US build is not working.

Reopening.  Plain build without de should work too and the extension still
should be installable. I'll try a build with en-US and de, too, though...

(FWIW, I will patch the whole license stuff out for Debian anyway as showing the
LGPL is nonsense)

sj: That said, it really works when bulding with de, too (my locale still is de_DE).
You really want to keep everyone which doesn't do a localized build or a locale
which is not supported by OOo out of installing this extension? As an example,
the report-builder extension gets around without that bogus limitation.

sj: and since the license shown for the de case is the *english* LGPL anyway
(ywes, that's right, it's the only legally valid one) it doesn't make sense to
have "localized" licenses anyway

Now en-US is always taken, independently from what is set in WITH_LANG. This
should solve all problems.

Rene: can you then please verify my changes (solenv/bin/licinserter.pl -r1.2.50.2)

sj: sorry, but I can't. still happens. (normal build with out --with-lang)

sj: (tried with LANG=C, LANG=en_US, LANG=de_DE.UTF-8)

set target 3.0

changed target