Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | W32-4NT m238 (to-be?) fails in openssl | ||||||
---|---|---|---|---|---|---|---|
Product: | Build Tools | Reporter: | quetschke | ||||
Component: | solenv | Assignee: | hjs <hans-joachim.lankenau> | ||||
Status: | CLOSED FIXED | QA Contact: | issues@tools <issues> | ||||
Severity: | Trivial | ||||||
Priority: | P2 | CC: | issues | ||||
Version: | current | ||||||
Target Milestone: | OOo 2.4 | ||||||
Hardware: | All | ||||||
OS: | Windows, all | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Issue Depends on: | |||||||
Issue Blocks: | 82202 | ||||||
Attachments: |
|
Description
quetschke
2007-11-29 14:14:30 UTC
The buildinf.h is patched by util/mk1mf.pl that writes: #define CFLAGS "$cc $cflags" Beside the point that /s in $cc should be quoted in a C string the main question is what the $cc is doing there?! seems to be the combination of windows native path and cygwin perl. hit the same problem while trying a merged nowrapcmd1/m238 tree. here CC must have \ delimiters for usage out of nmake (better resync nowrapcmd1...). commenting out that whole define works ;) I think this particular issue is not a "windows native path and cygwin perl" issue because the compiler complains about the backslashes. I guess this just accidentally works in the Hamburg environment because your CC is not having a path in front of it, probably it is just CC=cl.exe? (I'm guessing here) It works for the current W32-bash builds (not nowrapcmd) because CC="guw.exe /cygdrive/.../cl.exe" - no backslashes. And it will definitely break somewhere for nowrapcmd1 - I'll fix this after the resync. I guess the best fix (without testing it yet) is to change #define CFLAGS "$cc $cflags" to #define CFLAGS "$cflags" in util/mk1mf.pl. Masterfix, if it doesn't break your 4nt build and it's not too late? (Or remove the define, as you say that works too.) Created attachment 50025 [details]
remove compiler from CFLAGS define
Committed, plus a small makefile patch to nowrapcmd1 ok . |