|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Startup optimization wrt. first start wizard | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | kendy | ||||||
| Component: | code | Assignee: | Mathias_Bauer | ||||||
| Status: | CLOSED FIXED | QA Contact: | issues@framework <issues> | ||||||
| Severity: | Trivial | ||||||||
| Priority: | P3 | CC: | issues | ||||||
| Version: | 680m238 | ||||||||
| Target Milestone: | OOo 2.4 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
|
Description
kendy
2007-12-02 15:18:39 UTC
Created attachment 50049 [details]
The patch.
Thanks for the patch, Kendy. Andreas, please have a look. as->kendy: These patch makes sense for an OOo installation using a native splash screen only. Further it duplicates code which must be changed from now on two places. If you wish to introduce these new feature in OOo please send a new patch fixing the following issues: a) ALL code/checks involved in FirstStartWizard:isWizardNeeded() (e.g. including the check if the license file was update by an OOo patch) has to be moved to a new location. b) The old code has to be removed. Means: there must be only one place where those check is done. At least there will be one question: do you ever measured the time the office will be faster after those patch was applied :-) First we should make sure the code will do it's job right and will not bring new maintainence problem - then we can try to increase performance. Please come back with the new patch. Regards Andreas as: Sure - as I said, this is the least offensive version, and of course, I can provide a solution that is cleaner, but touches bigger amount of code. If you generally agree with the idea, I will gladly provide that ;-) As to the measurement - it saves about 130k of memory, and of course all the disk I/O + linking time. It is probably not too much, but OTOH you wouldn't belive how much such small wins we can get during startup so that in the end it is not only measurable, but even noticeable ;-) [Recently I found about 10 libraries that could be avoided during startup, and filed them as separate issues.] as->kendy: OK - if you will can avoid loading of 10 libraries - of course it will be measurable . So from this point of view the patch make sense. And yes - if you provide a more clean solution avoiding duplicate code - I agree with you and your patch :-) as->kendy: If there is a new patch available - please send these task back to me. Sure, I'll attach the new version that moves the necessary stuff to Desktop. Please have a look. If OK, I can create a CWS, or please commit somewhere. Thank you in advance! Created attachment 50445 [details]
The patch.
as: patch applied on cws "fwk82" .. and it seams to work :-) as->mba: Please verify these task on cws fwk82. Wizard must be shown normaly. Only it's place inside libs was changed. as->kendy: You should check if your optimization works now as aspected. I verified that the Wizard still is shown when necessary. Just for the record, the library is not loaded when not necessary. Sorry for the late reply :-( Thanks for the confirmation. Closing. |