Issue 84189

Summary: document-local UNO dialogs containing label controls cannot be loaded anymore
Product: General Reporter: Frank Schönheit <frank.schoenheit>
Component: uiAssignee: joerg.skottke
Status: CLOSED FIXED QA Contact: issues@framework <issues>
Severity: Trivial    
Priority: P2 CC: carsten.driesner, issues
Version: 680m238Keywords: regression
Target Milestone: OOo 2.4   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
document to reproduce the bug case none

Description Frank Schönheit 2007-12-03 10:04:25 UTC 
- open the document AWT_TREE_sample_code.odt attached to issue 82954
(http://www.openoffice.org/nonav/issues/showattachment.cgi/49297/AWT_TREE_sample_code.odt)
- press the contained button
=> the Basic IDE opens, pointing out an error in a call
     DialogLibraries.loadLibrary( "Standard" )
   This document in fact should contain a dialog library named "Standard", and
   therein a dialog. In m237, both are present, in m238, they aren't.
Comment 1 Frank Schönheit 2007-12-03 10:07:16 UTC 
Note: I was not able to reproduce this with a newly created document with an
embedded dialog. Not sure what's special about the referenced bug doc.

fs->mba: I strongly hope this isn't a regression of my changes with respect to
the AdjustMacroMode thing, which came in into m238 :-\. Going to debug a little.
Comment 2 carsten.driesner 2007-12-03 10:21:02 UTC 
cd: Set on CC.
Comment 3 Frank Schönheit 2007-12-03 10:37:46 UTC 
fs->tkr: This seems to be a regression of your "NoLabel" change. What happens is
that when the dialog is to be loaded, ElementDescriptor::readFixedTextModel
tries to translate an attribute "nolabel" to a property value of NoLabel. Which
leads to ElementDescriptor::read asking for the NoLabel property, which simply
does not exist at the FixedTextModel, thus an UnknownPropertyException is
thrown, which cancels the loading of the complete dialog.

Besides that I think the current behavior is *way too* intolerant (why is does
*complete* loading fail when there is an error with a single property?), it
seems the code silently assumes that there is a NoLabel property where there
actually is none.
Comment 4 Frank Schönheit 2007-12-03 10:40:32 UTC 
Created attachment 50061 [details]
document to reproduce the bug case
Comment 5 Frank Schönheit 2007-12-03 10:42:23 UTC 
The attached document is a stripped-down version: Just open it, and press the
button - this should display a simple dialog containing a fixed text only. In
m237 it works, in m238 it doesn't.
Comment 6 Frank Schönheit 2007-12-03 10:47:39 UTC 
Raising the priority to P2: Trying a "Tools / Macros / Organize Dialogs",
following by expanding the bug doc's node to display the contained dialogs,
actually crashes. Seems the organizer dialog is not catching exceptions thrown
by the core implementations (which is a bug of its own).
Comment 7 tkr 2007-12-03 14:33:35 UTC 
accepted
Comment 8 tkr 2007-12-04 10:12:11 UTC 
Fixed in tkr07. Was a merge conflict in toolkit.
Comment 9 tkr 2007-12-07 13:13:10 UTC 
TKR -> JSK: please verify
Comment 10 frank 2008-01-17 10:17:01 UTC 
found fixed on cws tkr07
Comment 11 joerg.skottke 2008-03-12 08:48:28 UTC 
Both module and dialog are present in the AWT_TREE_sample.odt and the attached
bugdoc works fine in ooh680m10. Closing