Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Remove external header guards from cppumaker-generated files | ||
---|---|---|---|
Product: | udk | Reporter: | thb |
Component: | code | Assignee: | jsc |
Status: | CLOSED FIXED | QA Contact: | issues@udk <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues, jsc |
Version: | current | ||
Target Milestone: | OOo 3.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
thb
2008-02-10 21:13:46 UTC
Target etc. @jsc: FYI, the big-bang incguards removal now takes place in CWS changefileheader Done en passant in CWS changefileheader (codemaker/source/cppumaker/includes.cxx). Fixed for cppumaker - jsc, want to tackle uno-skeletonmaker quickly tomorrow? I'd otherwise split this issue... Eek, missing the addressant - jsc, want to tackle uno-skeletonmaker quickly tomorrow? I'd otherwise split this issue... jsc -> thb: i have it already fixed on cws jsc21 with issue number i72964. It is fixed at least for cppumaker and i will check it for uno-skeletonmaker as well. I am not sure if i have fixed it there as well. yes, the uno-skeletonmaker is fixed as well @jsc: any objections if I keep the changes in changefileheader? They are exactly the same as you did in jsc21 (but confined to includes.cxx) - given that jsc21 does not seem to have a target date yet, and I'd like to reap the benefits for c++ code now... well the benefits are marginal and i don't see a real demand for it. You can do whatever you want but it doesn't make sense to fix the same things in 2 different cws. I thought it was clear that i will do it because i had the modules in my cws anyway and i had clearly communicated that i will do it. Who shall verify this issue? @jsc: please verify in CWS changefileheader verified on cws changefileheader closed, checked on master |