Issue 87094

Summary: crash selecting odt file for merge documents
Product: Calc Reporter: max.odendahl
Component: editingAssignee: oc
Status: CLOSED FIXED QA Contact: issues@sc <issues>
Severity: Trivial    
Priority: P2 CC: eric.bachard, issues
Version: DEV300m3   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---

Description max.odendahl 2008-03-16 19:55:24 UTC 
- create a new calc document
- select Edit - Changes - Merge Document or Tools - Merge Document
- select odt file 

--> crash
Comment 1 Mechtilde 2008-03-16 20:28:38 UTC 
I can confirm it
Comment 2 eric.bachard 2008-03-16 20:49:14 UTC 
Issue confirmed: another cause of crash could be compare .odt with .ods ..etc 

The top of the stack gives:

Thread 0 Crashed:
0   libtlmxi.dylib                 	0x00553eba String::String[in-charge](String const&) + 10
1   libscmxi.dylib                 	0x2424d962 ScDocShell::DialogClosedHdl(sfx2::FileDialogHelper*) + 132
2   libsfxmxi.dylib                	0x01e22d31 
sfx2::DocumentInserter::DialogClosedHdl(sfx2::FileDialogHelper*) + 437
3   libsfxmxi.dylib                	0x01eee9fb sfx2::FileDialogHelper::ExecuteSystemFilePicker(void*) + 51
4   libvclmxi.dylib                	0x011b6878 Window::~Window [in-charge]() + 23758
5   libvclmxi.dylib                	0x0123d56d component_getFactory + 127981
6   libvclmxi.dylib                	0x01012ea5 Application::Yield(bool) + 83
7   libvclmxi.dylib                	0x01012f27 Application::Execute() + 63
Comment 3 eric.bachard 2008-03-16 20:50:10 UTC 
+me on CC
Comment 4 oc 2008-03-17 09:18:26 UTC 
Hi Eike, please have a look
Comment 5 ooo 2008-03-17 13:21:09 UTC 
In ScDocShell::DialogClosedHdl() the SfxMedium* pMed is NULL.
Comment 6 ooo 2008-03-17 13:46:17 UTC 
In cws calcshare2:

sc/source/ui/docshell/docsh4.cxx  1.59.8.3
Comment 7 eric.bachard 2008-03-17 14:26:55 UTC 
ericb@er 

I tested the diff between -r 1.59.8.2 and -r 1.59.8.3 and I confirm there is no
longer crash.

Thanks a lot :-)
Comment 8 ooo 2008-04-01 11:08:11 UTC 
Reassigning to QA for verification.
Comment 9 oc 2008-04-02 09:22:45 UTC 
verified in internal build cws_calcshare2
Comment 10 amy2008 2008-08-05 11:44:38 UTC 
Verified in DEV300_m28 on WinXP.
Comment 11 oc 2008-08-05 13:39:37 UTC 
closed