|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | wrong percentage display in data label - approved | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | rafaelda <falecomigo> | ||||||||||||
| Component: | chart | Assignee: | kla <thomas.klarhoefer> | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> | ||||||||||||
| Severity: | Trivial | ||||||||||||||
| Priority: | P3 | CC: | IngridvdM, issues, kamataki, weizhao | ||||||||||||
| Version: | 3.3.0 or older (OOo) | Keywords: | regression | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||||||||
| Developer Difficulty: | --- | ||||||||||||||
| Issue Depends on: | |||||||||||||||
| Issue Blocks: | 72764, 88258 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
rafaelda
2008-04-09 06:44:57 UTC
Created attachment 52669 [details]
See the chart
Created attachment 52670 [details]
Sample spreadsheet with a chart
The Chart Type they are chosen is "percent stacked". Switch to stacked and all will be fine. No it won't. I think that by saying that I should change the type of chart you just admitted that "Percent stack" have problems in 2.4 so I guess I can say that it doesn't worksforyou. I'm reopening this issue because it doesn't works as it's expected and it's a regression since it was working fine in 2.3 and in 2.3.1. Unfortunately I deleted my copy of OOo 2.3.1 after I downloaded 2.4 so I won't be able to do a screen capture of how it was working correctly in that version but I will do a mock up. See the new attached file. In Janeiro's bar the blue part should show the vlaue "4,03%" because R$ 25,80 is 4,03% of all the expenditures of Janeiro (25,80+250+13+24+327,89). The red part of Janeiro's bar should show the value "39,02%" because 250 is 39,02% of all the expenditures fo that month. It worked this wsay in 2.3 and 2.3.1 and it should work this way in 2.4. Created attachment 52706 [details]
Correct Percentage Mock Up
I can confirm the problem and take the issue. confirmed ->weiz: Please have a look at this problem. Thanks a lot! ->iha: the patch is finished, I only delete two lines in the function "getLabelTextForValue", and I noticed that the function is related to issue 43489, hope my modification wouldn't effect that issue. Created attachment 52747 [details]
patch_080411
->weiz: Thanks a lot! As far as I tested it, the fix works! Only a bit code hygiene should be done: As the parameter fSumValue is useless now please remove it from the method. For me the current patch even does not compile on windows as unused parameters produce a warning which are treated as error per default in OOo. Thanks, Ingrid. Created attachment 52825 [details]
patch_080415
->iha: The new patch is submitted. Thank you! ->weiz: Thanks a lot! The patch works fine. I checked it into CWS chart26. I think this fix should be integrated into OOo 2.4.1 as it is a bad regresison. So I changed the target accordingly. ->Thomas, please verify in CWS chart26. You will need to press F9 or double-click on the chart in the example document thus a new image is generated showing the correct label. added "approved" to the title, because it will be easier to work with the 2.4.1 meta issue during release status meetings. Seen ok in CWS chart 26 -> verified in CWS chart26 Current status will not switched to verified, after the issue is also verified in CWS c03v13 verified Seen ok in current master -> closed |