Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Asian strings truncated in Smooth Lines dialog | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | General | Reporter: | yuko <yuko.ohsumi> | ||||||||||
Component: | chart | Assignee: | stefan.baltzer | ||||||||||
Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> | ||||||||||
Severity: | Trivial | ||||||||||||
Priority: | P3 | CC: | hdu, IngridvdM, issues, philipp.lohmann | ||||||||||
Version: | 3.3.0 or older (OOo) | Keywords: | CJK | ||||||||||
Target Milestone: | --- | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||
Developer Difficulty: | --- | ||||||||||||
Issue Depends on: | |||||||||||||
Issue Blocks: | 72764 | ||||||||||||
Attachments: |
|
Description
yuko
2008-05-14 06:37:02 UTC
Created attachment 53607 [details]
English Smooth Lines dialog
Created attachment 53608 [details]
Japanese Smooth Lines dialog
SBA: For target OOo 3.0, UI freeze has passed and the final translation round is currently under way. Set target to OOo 3.x. Reassigned to iha Component changed to Chart The position and sizes for the controls in this dialog are calculated dependent on the current text length. In this case the method RadioButton::CalcMinimumSize does return a wrong width for the given string. Using an even longer english string makes no problems. Maybe the string itself is buggy somehow? With my version I see a square somewhere in the text at the screen. Also the string seems to end with a space within the localize.sdf file. Don't know whether that is ok. The string in the localize.sdf file is: chart2 source\controller\dialogs\tp_ChartType.src 0 radiobutton DLG_SPLINE_PROPERTIES RB_SPLINES_CUBIC 0 ja データãƒÂイントãªã—平滑線ã¤ãªãÂŽ 2002-02-02 02:02:02 @sba, please let someone who knows japanese check the string. @hdu, do you know the text size calculation methods in vcl? Do you maybe have an idea why the size of that special japanese string is calculated wrongly? > hdu, do you know the text size calculation methods in vcl? Yes ;-) As a rule of thumb the text size is calculated correctly if Writer handles it correcly in "Online Layout" mode. > Do you maybe have an idea why the size of that special japanese string is calculated wrongly? Recently a developer had a similar problem with text size on a button seemingly being zero. The problem was that he called GetControlText() on the button to get the string. But the control text is not the button text, but was an empty string in that case. And the size of the empty string was... drumroll... zero. Anyway, I can't read that specific string in the comment above even when changing the browser's View->Encoding. What encoding is it? I checked the localize.sdf and it looks ok as follows. chart2 source\controller\dialogs\tp_ChartType.src 0 radiobutton DLG_SPLINE_PROPERTIES RB_SPLINES_CUBIC 0 ja データãƒã‚¤ãƒ³ãƒˆãªã—平滑線ã¤ãªãŽ 2002-02-02 02:02:02 @yuko, thanks! @hdu, sorry I messed up the string. I think the copy from yuko is the correct one, or look at the localize.sdf file directly. It is in chart2\source\controller\dialogs\localize.sdf . Search for RB_SPLINES_CUBIC. The control that gets this text is the RadioButton m_aRB_Splines_Cubic in file chart2\source\controller\dialogs\tp_ChartType.cxx. Within constructor SplinePropertiesDialog::SplinePropertiesDialog the method m_aRB_Splines_Cubic.CalcMinimumSize() is called. @weiz, please have a look at this one. It might be the same problem that leads to issue 95051 - the size of Asian texts seem to be calculated wrongly . The textsize measurement seems to be done before ImplWindowAutoMnemonic() has done its work, so the automnemonic string extension is not taken measured. That's the first time I've seen+debugged that code, so for more questions PL might be the better contact. From my rudimentary understanding calling Dialog::StateChanged(STATE_CHANGE_INITSHOW) would prepare the AutoMnemonic so the individual controls have their correct text. Created attachment 57604 [details]
patch_081031
@iha: The patch is submitted. Please let me know if you have any suggestions. Thanks! @weiz, thanks! The patch works, only it is necessary to call adjustSize after the repositioning of the controls. Otherwise with some languages the dialog becomes to small. I commited aa adapted fix to CWS chart35. Created attachment 59271 [details]
example for zh-TW
@Kla, please verify in CWS chart35. Thanks! Use the zh-TW install set. Thx SBA for take over this issue. Verified in CWS chart35. OK in OOo 3.2 RC1 (OOO320_m8). Closed. |