Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing
|Summary:||Opening datasource from Calc file, saved in 3.0, triggers 'Update' message|
|Component:||code||Assignee:||AOO issues mailing list <issues>|
|Status:||CONFIRMED ---||QA Contact:|
|Priority:||P3||CC:||issues, Mathias_Bauer, mikhail.voytenko|
|Issue Type:||DEFECT||Latest Confirmation in:||---|
Description cno 2008-05-22 09:04:45 UTC
There is an 'Update' message, that is triggered if you open a 3.0-saved file in OOo 2.4.0. Now, opening datasource from Calc file, saved in 3.0, triggers that same window ... Disturbing at the least.
Comment 1 Frank Schönheit 2008-05-22 13:30:11 UTC
fs->pb: The message box is raised in SfxObjectShell::DoLoad, when the document which is being loaded has "later" ODF version than the current OOo version uses. There's a number of problems here: - The code checks whether the document was loaded with an interaction handler. Well, nowadays *every* document is loaded with an interaction handler, because the LoadEnvironment code adds a dummy interaction handler, even if the caller didn't pass one. Thus, the check does not work, it always evaluates to TRUE. - Raising the dialog *bypassing* the interaction handler sounds like a hack to me. This should be some kind of interaction request which is given to the handler - finally, exactly this is the purpose of an interaction handler - allow to handle interactions, instead of letting the core code do this itself. - Raising the dialog during loading the document sounds questionable to me, to. I would expect this is done when the first non-hidden controller is attached to the document. However, this touches the much wider field of how to generall handle interactions during loading documents. In the past, we introduced MediaDescriptor properties like MacroExecutionMode and UpdateMode for every kind of interaction we anticipated during loading, an analogous situation here would be to introduce some kind of FileFormatWarningMode. However, I really think this approach doesn't scale, and the problem should be solved more generally ... Well, in a later life, perhaps. - For really fixing the problem between 3.0-generated documents and a 2.4-installation, we would need to fix 2.4. However, I don't really think this issue is worth a micro-update. So, I suggest the fix is made, but only for "future" releases, in that if a 3.0 encounters a document which was written with a 3.x, the message box is properly routed via the interaction handler. When you (or whoever in your team is responsible for this) implemented this, please send the bug back to us, so we can introduce an "fake handler" which silences this particular interaction from without our spreadsheet driver.
Comment 2 drewjensen.inbox 2008-05-22 14:04:27 UTC
This is not the only way to trigger the update dialog. If you create a Writer file under 2.4 and insert a Calc file created in 3.0 as an OLE object and select Linked - the dialog to update is displayed when the file is imported. It is not displayed again when the writer file is opened. Just a FYI as it is not really about this issue.
Comment 3 Frank Schönheit 2008-05-22 14:11:02 UTC
Well, this information is interesting at least when it comes to deciding about the severity of the issue. I am unsure we already jumped over the "qualify for 2.4.x" hurdle, but the more flavors of this bug, the more likely, IMO ...
Comment 5 pb 2008-07-15 05:19:38 UTC
pb: typo in cc fixed.