|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | framework: incredibly suspicious ";" location | ||||||
|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | caolanm | ||||
| Component: | code | Assignee: | carsten.driesner | ||||
| Status: | CLOSED FIXED | QA Contact: | issues@framework <issues> | ||||
| Severity: | Trivial | ||||||
| Priority: | P3 | CC: | issues | ||||
| Version: | DEV300m29 | ||||||
| Target Milestone: | OOo 3.1 | ||||||
| Hardware: | All | ||||||
| OS: | Linux, all | ||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||
| Developer Difficulty: | --- | ||||||
| Issue Depends on: | |||||||
| Issue Blocks: | 92941 | ||||||
| Attachments: |
|
||||||
Created attachment 55900 [details]
patch to fix
FWIW: if the patch is acceptable I can take it into cmcfixes49 hi cmc, i was just noticing that you filed a couple such issues, and wondering how you found these? of course to me these issues are just further evidence that c syntax is just plain evil... "If I were going to write the Ten Golden Rules of Software, the top of the list would be: Error Prone == Evil Although this concept is obvious to 99.999% of the general population, it's only accepted by 2% of computer programmers. The remaining 98% subscribe to a competing philosophy, namely: "Error Prone = Manly". Never mind that they just assigned "Manly" to the variable "Error Prone", and the expression always returns true; that happens to be the correct value in this case, so it's an acceptable hack." -- Steve Yegge oh, and mba is on vacation util end of august. See the parent issue, I'm just running through the warnings listed by our shiny new compiler, fixing the trivial ones and putting out notices for the non-trivial ones. Carsten, please take over. I assume the patch is correct ;-) but perhaps you want to think about the possible consequences of it as most obviously it was supposed to do something. ;-) cd->cmc: Thanks for the patch. Yes, that's definitely a typo and no way intended. Fortunately this method is seldom, may be currently never used. cd: Patch accepted and applied. cd: Verified. seen in DEV300_m46 and OOO310_m11 |
see ConfigurationAccess_UIElementFactoryManager::getAllFactories() in framework/source/uifactory/uielementfactorymanager.cxx while ( pIter != m_aUIElementFactoryManagerMap.end() ); { aSeq[nIndex++] = pIter->second; ++pIter; } there's surely no way in hell this is what's intended