Issue 93820

Summary: Rename 'save as picture' to better reflect it's functionality
Product: Draw Reporter: wolframgarten
Component: uiAssignee: AOO issues mailing list <issues>
Status: CONFIRMED --- QA Contact: Armin Le Grand <Armin.Le.Grand>
Severity: Trivial    
Priority: P3 CC: arielch, Armin.Le.Grand, cno, issues, rainerbielefeld_ooo_qa, rb.henschel
Version: OOO300m4   
Target Milestone: AOO Later   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: 4.0.0
Developer Difficulty: ---

Description wolframgarten 2008-09-12 12:33:48 UTC
I insert a picture and crop it with the new crop tool.
After that I call the context menu, select save picture as and save the cropped
part as jpg (any other format will do, too).
Using the insert picture function I load the new picture back into the document.
It shows the pre-cropping state. IMHO this is not the intention of the user.
A workaround would be to use the file/export/selection function to get the
cropped picture saved.
Comment 1 Rainer Bielefeld 2013-05-16 17:26:00 UTC
Still Reproducible with server installation of  "AOO 4.0.0-Dev – English UI / German locale [AOO400m1(Build:9700) - Rev. 1482523 Rev.1482259 (2013-05-15)]" on WIN7 Home Premium (64bit)", own separate user profile

I see this one as a bug.

Suggested workaround will not work because of 
"Bug 74211 - Exporting cropped image (selection) shows wrong area"
"Bug 25744 - vertical borders of visible area of cropped picture shifted to the right during 'Export - Selection'"
Comment 2 Ariel Constenla-Haile 2013-05-16 22:30:20 UTC
This happens also on the "Save Graphics..." in Writer's context menu.
Comment 3 Armin Le Grand 2013-05-17 17:00:33 UTC
ALG: Indeed ignores cropping, but maybe this is by purpose. Compared to 'export' which is intended to export in the given state, you here save an existing picture, may it be cropped or not.
Comments?
Comment 4 Armin Le Grand 2013-05-17 17:18:18 UTC
ALG: From the code it looks like being done on purpose; It's the only way (except hacking the ODF file) to easily get the original data out. It is also only offered for Graphics - Bitmap and Metafiles, not for normal draw shapes. Maybe better change the name to 'export graphic...' to make more clear what should happen here.
Is there a description in the Help files which could give a hint what was intended here?
Comment 5 Armin Le Grand 2013-05-17 17:29:58 UTC
ALG: Found https://issues.apache.org/ooo/show_bug.cgi?id=63795, seems to have had to do with this one (also found when using ".uno:SaveGraphic" in OpenGrok in the helpcontent2 project. It says:

[graphics-features] new/impresssavegraphics : context menu to save pictures from
graphic shapes to files

Only from GraphicShapes: Export the originals...?
Comment 6 Ariel Constenla-Haile 2013-05-17 17:46:20 UTC
(In reply to comment #4)
> Is there a description in the Help files which could give a hint what was
> intended here?

Open the context menu, and press F1 when the menu item is highlighted, or press Shift+F1 to see the extended tip. This last one, in Draw, says:

"To export a bitmap in Writer [sic.]: Right-click the bitmap, choose Save Graphics. You see the Graphics Export dialog. Enter a file name and select a file type."

This is main/helpcontent2/source/text/shared/guide/insert_bitmap.xhp
the bookmark for "hid/.uno:SaveGraphic"

In Writer, the "Graphics Export" dialogue is simply the file picker, it let's you save the graphic in a different format, but it does not show any dialogue to change the filter settings, as Draw/Impress do.

Saving the original image has pros and cons depending on the application:

a) in Draw/Impress you can save the original image from the context menu. If you want to save the modified graphic object shape, you export the selection with File - Export (IIRC exporting the selection is broken in svg and swf export)

b) but Writer has no way to export the selected graphic using the graphic export filters, so it would be also nice to be able to save the modified graphic object shape.
Comment 7 Regina Henschel 2013-05-17 18:32:49 UTC
Help: "The <emph>Save as Picture</emph> command in the context menu saves the picture without any filter effects, if the picture was inserted as a linked picture. An embedded picture will always be saved or exported with filters applied.<comment>see i70055</comment>" from helpcontent2\source\text\shared\guide\insert_bitmap.xhp

But the text is false in respect to "linked" and "embedded". Also for embedded graphics always the original graphic is saved.

Wiki: "Any changes made in the Crop dialog change only the view of the picture. The original picture is not changed. If you want to export a cropped graphic, you must do it through File > Export. If you use the option Save as Picture from the context menu, the changes are not exported." as "Caution" in http://wiki.openoffice.org/wiki/Documentation/OOo3_User_Guides/Draw_Guide/Editing_Pictures 

My opinion:
The feature should remain this way for Draw. It has worked this way from the beginning and is the only way to get the original graphic without unpacking the file (as you mentioned). The feature is documented this way. All users which need the transformed graphic can use File > Export, which in addition gives additional settings for dpi and compression, for example.

For Writer and Calc it would be better to implement a "export selection" similar to print selection or pdf from selection, which is already possible now.
Comment 8 Armin Le Grand 2013-05-27 09:38:24 UTC
ALG: All this confirms that it is by purpose that this function is exporting the unchanged, original graphic. I opt for keeping it this way, as also others suggested. I also think that to avoid confusion in the future this should be renamed, what about

'Save as picture' -> 'Save original content'

or similar. Suggestions welcome.