|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Slideshow crashes on exit (multi-screen) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | gsl | Reporter: | thb | ||||||
| Component: | code | Assignee: | Andre <awf.aoo> | ||||||
| Status: | CLOSED FIXED | QA Contact: | issues@gsl <issues> | ||||||
| Severity: | Trivial | ||||||||
| Priority: | P3 | CC: | caolanm, clippka, issues, orw, philipp.lohmann, sven.jacobi | ||||||
| Version: | current | ||||||||
| Target Milestone: | 4.0.0 | ||||||||
| Hardware: | Unknown | ||||||||
| OS: | All | ||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
|
Description
thb
2008-09-17 21:49:23 UTC
Created attachment 56596 [details]
proposed fix
@af: any negative implications you're aware of, when moving the dispose call in SlideShow::end()? Looks OK to me. *** Issue 111758 has been marked as a duplicate of this issue. *** @af: sorry for the lag. got a cws I could put this into, by chance? impress191 should be fine, just wait until tomorrow since sj wants to resync it to the recent m80 @sj/@cl: could one of you commit it then, please, after the merge? Sadly hg does not allow those easy partial checkouts we did back in the day... I'm fine with adding the patch to cws impress191 but I like to reproduce it first. Can you please add a description how the crash is reproducable? FWIW I can reproduce it with with a dual screen setup, with gtk vclplug in operation and the cairo canvas toggled on and the presenter screen installed. Start any presentation and go full screen. Press escape. Should then die with an XError. yep. sadly this only manifests under cairo & multiscreen. but apart from rolling a full-blown "screen nums have changed, drop all your system handles" infrastructure, there's no other way to fix this. OOo 3.3 is in showstopper-mode. This issue is too old to be a stopper for the current release. I change the target to OOo 3.x. Please change the target accordingly when a fix is near to be integrated into a code line. Created attachment 76940 [details]
Patch Update
Updated the patch so that it can be applied again. (and fixed some minor typos in new comments)
It looks like this never was integrated to impress191. Sending sd/source/ui/slideshow/slideshow.cxx Sending vcl/source/window/wrkwin.cxx Transmitting file data .. Committed revision 1195527 Thank you! Author has expressed he does not want his code included under an Apache License: "With the header changes Andrew was making successively (http://svn.apache.org/viewvc?view=revision&revision=1198285 and http://svn.apache.org/viewvc?view=revision&revision=1198320), I disapprove application, and subsequent re-licensing of my patch to AL2." commit -m "i94007 - Revert r1195527 at author's request." Sending sd/source/ui/slideshow/slideshow.cxx Sending vcl/source/window/wrkwin.cxx Transmitting file data .. Committed revision 1198909. I will leave the issue open for reference until we have a complete fix. The content of attachment 56596 [details] has been deleted by hdu@apache.org who provided the following reason: not applicable on request of thb@documentfoundation.org The token used to delete this attachment was generated at 2012-07-11 12:45:37 UTC. The content of attachment 76940 [details] has been deleted by hdu@apache.org who provided the following reason: not applicable on request of creator af@a-w-f.de The token used to delete this attachment was generated at 2012-07-11 12:46:38 UTC. Thanks Herbert for removing the patches. Now we can use the idea described in the first comment for fixing this again. "af" committed SVN revision 1360602 into trunk: #i94007# Dispose controller earlier when slide show is ended to avoid crash. Fixed. Update target to version containing the fix fixed in 4.0.0 |