Issue 95934

Created attachment 57749 [details]
test file 1

Created attachment 57750 [details]
test file 2

Created attachment 57751 [details]
test file 3

This issue depends on Issue 95714.

accepting the issue.

Created attachment 57982 [details]
proposed patch for chart2

Created attachment 57983 [details]
proposed patch for sc

Let's shoot this for 3.2.

Hi, is this still on track for 3.2?

Yes.  But this may potentially need an extension in the ODF spec.  The bad news
is that the ODF TC is closed for new proposal right now, prepping for 1.2
release.  So, it will depend on whether this requires a ODF extension, and if
so, when we can get an approval from the TC.

BTW, I think this is for Ingrid, but this change requires two new properties in
chart2.ChartType object "Stacked" and "Percent", while the properties with the
same names in the Diagram object are deprecated.  That's the only way to support
this change since Excel's chart allows stack mode per chart, not per diagram.

Ok.  I'm not sure if I can make this in for 3.2.  Re-targeting it to 3.x.

registered this issue with koheichart02.  I will also look into what kind of
change we need to make in the ODF file format....

There is one problem with handling ODF import and export.  Right now, ODF
doesn't have the concept of chart types.  The chart:series element, which stores
individual data series, occurs immediately below the chart:plot-area element. 
But for the mixed-type charts to be stored correctly we need to store the chart
types themselves.  Ideally the element for the chart types, say,
chart:chart-type, needs to be below the chart:plot-area but the parent of the
chart:series elements.

So, instead of storing

<chart:plot-area>
    ...
    <chart:series/>
    <chart:series/>
    <chart:series/>
    ...
</chart:plot-area>

as we currently do, we need to store it as

<chart:plot-area>
    ...
    <chart:chart-type>
        <chart:series/>
        <chart:series/>
    </chart:chart-type>
    <chart:chart-type>
        <chart:series/>
    </chart:chart-type>
    ...
</chart:plot-area>

Using this structure is also very similar to how the chart model is structured
internally, so it only makes sense to do it this way.

This only issue with this is obviously the ODF backward compatibility &
potential delay in getting (pre-)approval from the TC.  But to me, this is the
best way to approach this.

I have a better idea.

<style:style style:name="ch10" style:family="chart">
    <style:chart-properties chart:stacked="true" ... />
</style:style>
...
<chart:plot-area>
    ...
    <chart:type chart:class="chart:bar" chart:style-name="ch10"/>
    <chart:series chart:class="chart:bar"/>
    <chart:series chart:class="chart:bar"/>
    <chart:series chart:class="chart:line"/>
    ...
</chart:plot-area>

Instead of having a new parent element nest the chart:series elements, we can
add a new sibling element "chart:type" which defines some additional attributes
for the used chart type(s).  This one is less intrusive & will probably mesh
well with the current XML structure.

A 3rd version...

<style:style style:name="ch10" style:family="chart">
    <style:chart-properties chart:stacked="true" ... />
</style:style>
...
<chart:plot-area>
    ...
    <chart:class chart:name="chart:bar" chart:style-name="ch10"/>
    <chart:series chart:class="chart:bar"/>
    <chart:series chart:class="chart:bar"/>
    <chart:series chart:class="chart:line"/>
    ...
</chart:plot-area>

Instead of chart:type, use chart:class as the element name, and use chart:name
attribute to name it.

This <chart:class> element should be present only when the specified chart type
has some non-default attributes.

@iha: Ingrid, does the last version of the XML structure look good to you?  Do
you have any better ideas?

@kohei, the percentage flag does affect the y-axis. As long as we have only one
percentage flag this is no problem. If we now have different percentage flags
for the same axis the handling needs to be specified.
Moreover the old excel is buggy in doing here. It displays a value of 88 (from a
not stacked series) as 88% at the percentage axis (example
simplePercentStacked.xls). This is wrong. The newer excel version displays the
88 correct at 8800%.
So if you load the example files in a more recent excel version you will see
that the result is again unexpected for the user.
All in all I am not convinced that this feature (relying on bugs in old excel)
is worth the effort... .
Anyhow for the concrete file format issue, why not using the stacked properties
directly at the series? For the pure stacked property this is much nearer to the
current implementation and from the schema it would be allowed right now already.

Reset assignee on issues not touched by assignee in more than 1000 days.

Status changed: 2 patches has been proposed
Somebody to push these?