Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Hidden last slide of presentation shown when go backwards from black finish-screen | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | aksdb | ||||||
Component: | viewing | Assignee: | groucho266 | ||||||
Status: | CLOSED FIXED | QA Contact: | |||||||
Severity: | Normal | ||||||||
Priority: | P3 | CC: | doneyourself, hanya.runo, issues, rainerbielefeld_ooo_qa | ||||||
Version: | OOo 3.0 | ||||||||
Target Milestone: | 4.1.0 | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
See Also: | https://issues.apache.org/ooo/show_bug.cgi?id=120159 | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | 4.0.0 | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Description
aksdb
2008-12-11 09:38:34 UTC
Reproducible. Reassigned. Still Reproducible with server installation of "AOO 4.0.0-Dev – English UI / German locale [AOO400m2(Build:9701) - Rev. 1493305 Rev.1491054 2013-06-14]" on WIN7 Home Premium (64bit)", own separate user profile You can try with Attachment 80858 [details] for Bug 120159 Additional Info: --------------- a) This one is not "Trivial", if a presenter wants to keep a slide hidden it is more than bad if his plan becomes frustrated by AOO b) Competitors: Respect hidden last slide also in this particular case: * LibreOffice 4.2.0.0.alpha0+ Build ID: f4a4fee523ff8a6d272eabda2ce9ca96bd3bbbb TinderBox: Win-x86@6, Branch:master, Time: 2013-06-14_23:53:13 Same Problem: * Lotus Symphony 3 Release 3.0.1 Revision 20120110.2000 No possibility to hide slides: * Calligra c) Relations: "Bug 120159 - Hidden start slide shown in slide show" Created attachment 80861 [details]
Proposed patch to fix this problem
When the mode is SHOWWINDOWMODE_END in SlideshowImpl::gotoPreviousSlide method
defined in sd/source/ui/slideshow/slideshowimpl.cxx,
previous slide index is calculated with mpSlideController->getSlideIndexCount() - 1.
This way is wrong, getSlideIndexCount method returns size of vector that contains
slide indexes.
At this time, AnimationSlideController::getCurrentSlideIndex method returns last
index of the visible page if the show is proceeded without END key.
When I push END key to move to the last slide, the last slide in the slides is
shown even the page is hidden.
So I introduced new method to get last visible slide from the list of slide indexes.
Attached patch in Comment 3 is bad. Hidden slides should be considered that they are visible once they have shown. So, getCurrentSlideIndex is the choice in this case. Comment on attachment 80861 [details]
Proposed patch to fix this problem
Set obsolete flag to the attached file.
Created attachment 80869 [details]
Patch to use current slide index to be back to last shown slide
Using AnimationSlideController::getCurrentSlideIndex method to get last slide index.
"hanya" committed SVN revision 1557152 into trunk: #i97129# fix hidden slide shown when going back to previous slide from finish... Fixed on trunk. verified on windows7 on AOO410m15(Build:9761) - Rev. 1583666 2014-04-01 13:53:14 (Di, 01 Apr 2014) |