Issue 97384

Summary: Deleting characters and insert a Writer file under Record Changes mode crashes Writer
Product: Writer Reporter: amy2008 <amy2008>
Component: codeAssignee: michael.ruess
Status: CLOSED FIXED QA Contact: issues@sw <issues>
Severity: Trivial    
Priority: P2 CC: issues,,,, ooo.redflag
Version: DEV300m37Keywords: crash
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on:    
Issue Blocks: 84292    
Description Flags
patch none

Description amy2008 2008-12-18 07:54:35 UTC
Can reproduce it with DEV300m37 on WinXP and Fedora

How to reproduce it
1 Create a new Writer document and type some characters
2 Edit - Changes - Record, delete the characters you just typed
3 Insert - File, 'Insert' dialog opens, select a *.odt file and hit 'Insert'
4 Click 'Undo' on Standard Toolbar about 3 or more times

OOo crashes

Undo works well

Li Meiying
Comment 1 michael.ruess 2008-12-19 14:19:28 UTC
MRU->AMA: it looks, that the Undo buffer is heavily confused by this row of
action in "Track changes" mode. After inserting the file, the Undo-Buffer (look
Undo-controller) shows many empty entries.
Comment 2 amy2008 2008-12-22 02:13:37 UTC
Meiying->MRU: Exactly, I've noticed the badly confused Undo buffer, but I can't 
confirm it. Indeed, there are one or more empty entries which should do some 
operations, but they are not. I guess this issue occurs due to these empty 
Comment 3 majun51 2009-08-24 09:12:14 UTC
Created attachment 64331 [details]
Comment 4 majun51 2009-08-24 09:21:20 UTC
Please have a check to this patch,thanks in advance.
Comment 5 2009-09-28 17:41:43 UTC
hi majun51,

investigating a bit, it looks like the po->Read() call moves the redline, and
the code in SwReader::Read() does not expect that...

attached patch looks good to me. i'll see that it gets into 3.3 version.

thanks for the patch!
Comment 6 2009-10-09 10:42:36 UTC
fixed in CWS sw33bf01 (patch applied)
Comment 7 2009-11-12 10:43:16 UTC
please verify
Comment 8 michael.ruess 2009-11-16 13:39:52 UTC
Verified fix in CWS sw33bf01.
Comment 9 michael.ruess 2010-01-14 13:10:22 UTC
Checked fix in DEV300m68.