Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Request Landscape Style be in Available Calc Styles | ||
---|---|---|---|
Product: | Calc | Reporter: | joeconner <joeconner> |
Component: | ui | Assignee: | AOO issues mailing list <issues> |
Status: | CONFIRMED --- | QA Contact: | |
Severity: | Trivial | ||
Priority: | P3 | CC: | elish, hanya.runo, issues, joeconner, rb.henschel |
Version: | OOO300m9 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Latest Confirmation in: | --- |
Developer Difficulty: | --- | ||
Attachments: |
Description
joeconner
2009-01-17 21:09:49 UTC
Created attachment 59446 [details]
Calc Landscape Template
Why has no one acknowledged this issue? Is a Landscape style ever going to be added to CALC? Useful enhancement. Created attachment 83413 [details]
Patch to add landscape page style for Calc
With swapped page width and height from the default paper size with landscape flag.
Created attachment 84416 [details]
File contains landscape style that added by the attached patch
The attached file that contains new landscape style stored by the office the patch applied,
have to be opened without any problems on older version.
I have not applied the patch, but from the code I see two questions in the patch: (1) The new style is missing in ScStyleSheetPool::CopyStdStylesFrom( ScStyleSheetPool* pSrcPool ) see comment // neue Eintraege auch bei CopyStdStylesFrom eintragen at the beginning of ScStyleSheetPool::CreateStandardStyles() The comment means translated, "put new items into CopyStdStylesFrom too". (2) Line pSheet->SetParent( aStrStandard ); ??? DO have page styles a parent? That is not possible in the UI. (In reply to Regina Henschel from comment #6) > (1) > The new style is missing in ScStyleSheetPool::CopyStdStylesFrom( > ScStyleSheetPool* pSrcPool ) > see comment > // neue Eintraege auch bei CopyStdStylesFrom eintragen > at the beginning of ScStyleSheetPool::CreateStandardStyles() > The comment means translated, "put new items into CopyStdStylesFrom too". Thank you. I did not notice the comment. > (2) > Line > pSheet->SetParent( aStrStandard ); > > ??? DO have page styles a parent? That is not possible in the UI. It seems it is not required. Landscape style is not child of Default style in Writer. I will remove it. Hierarchical structure of cell style can be changed with UI by drag and drop on hierarchical mode of Styles and Formatting. But it can not be done with page style. Created attachment 84428 [details]
Patch to add landscape page style for Calc
Update the patch.
|