Issue 100116 - Properties of form controls not usable
Summary: Properties of form controls not usable
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO310m4
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: marc.neumann
QA Contact: issues@framework
Keywords: oooqa, regression, release_blocker
Depends on:
Blocks: 95768
  Show dependency tree
Reported: 2009-03-11 10:28 UTC by Mechtilde
Modified: 2009-04-17 04:31 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

suggested patch (906 bytes, patch)
2009-03-11 16:12 UTC, philipp.lohmann
no flags Details | Diff
some vague thoughts (1.82 KB, patch)
2009-03-11 17:23 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Mechtilde 2009-03-11 10:28:25 UTC
this is a regression

One Example step-by-step

Open a Writer dokument
make toolbar "Form control" (German Formular-Steuerelemente) visible
draw a control like a text field
choose properties

=> you can't edit anything in the properties
you can't give the focus to this dialog box

Same for other controls like button etc.
Same in Basic dialogs
I assume that all form controls in all applications are affected
Comment 1 marc.neumann 2009-03-11 10:53:03 UTC
Hi Mechtilde,

I can't reproduce this. I can edit the properties without any problem.
Tested in OOO310_m4 on linux.

Do you do anything else?

Bye Marc
Comment 2 vitriol 2009-03-11 11:23:15 UTC
I can't reproduce on Win Vista. It seems working fine.
Comment 3 2009-03-11 12:24:39 UTC
This is true for all property windows like form control properties in the report
builder, the navigator, stylist and so on.

Open a new Writer document and open the navigator (undock it if necessary).

Note that it doesn't get input focus (cannot be controlled with keyboard) and
its titlebar isn't set to 'active window'

Furthermore the window doesn't show up in the window list of the underlying
window manager anymore.
Comment 4 Stefan Weigel 2009-03-11 12:43:37 UTC
Bug reproduced in the following environments:

* Debian/Lenny XFCE
* Arch Linux with Openbox
* Ubuntu Linux 7.10 and 8.04 (Gnome) with Visual Effects set to "normal"

(No malfunction with Ubuntu/Gnome, when Visual Effects set to "none")

Bug seems to apply to all non-modal popup windows.
Comment 5 michael.ruess 2009-03-11 13:11:10 UTC
Can also confirm this issue using "visual effects Extra" on ubuntu 8.10. 
Works fine without these effect.
Comment 6 marc.neumann 2009-03-11 13:17:26 UTC
I can also reproduce this on ubuntu with xfce4 windowmanager.
No problem with "SAL_USE_VCLPLUGIN=gen".

I reassign this to "pl".
Comment 7 philipp.lohmann 2009-03-11 16:12:52 UTC
Created attachment 60888 [details]
suggested patch
Comment 8 philipp.lohmann 2009-03-11 16:18:29 UTC
cmc: this came in with the _NET_WM_USER_TIME settings. The reason is that we now
state, SAL_FRAME_STYLE_TOOLWINDOW would mean "we don't accept the focus" which
the window manager in question obediently does. I should have seen that at the
time, but didn't. Obviously on many WM's this WM_HINT setting does not work
appropriately nowadays or this would have been obvious.

Question: does the intended behaviour still work for you with the attached patch
(which simply removes the "set_accept_focus(false)" for tool windows (e.g. the
form control properties, the navigator and stylist) on Metacity and compiz ?
Because actually this is wrong; these windows DO accept the focus, they just
don't want it initially - which the _NET_WM_USER_TIME is for. With the attached
patch it works as expected on Xfwm4.
Comment 9 philipp.lohmann 2009-03-11 16:24:47 UTC
cmc: at least on metacity 2.22.0 on my ubuntu 8.04 the behavior is still as
desired if I remove the "set_accept_focus(false)"
Comment 10 philipp.lohmann 2009-03-11 16:39:01 UTC
in the works
Comment 11 caolanm 2009-03-11 17:23:24 UTC
Created attachment 60890 [details]
some vague thoughts
Comment 12 caolanm 2009-03-11 17:37:12 UTC
So, FWIW, here's a few things to test that give the set of things trying to be
addressed in the first place IIRC

metacity or compiz or xfce etc...

high priority:
Keyboard should be able to navigate the "navigator" of F5 and the "style" of F11
Keyboard should work in the control properties dialog

low priority:
Press F5 and F11 in writer to show/hide those floating dialogs. Window manager
should not end up focusing nothing at all (i.e metacity)
Insert->table and click in it to get the floating table toolbar. Window manger
should not pulse "activity" (i.e. compiz)

even lower priority:
Press F5, or F11. Main window should retain focus unless someone clicks on the
floating dialog (i.e. compiz)
click in a table to get table floater, alt tab to another window, alt tab back.
state should be the same after returning as it was on leaving
Comment 13 philipp.lohmann 2009-03-11 18:06:55 UTC
fixed in CWS ooo31gsl5
Comment 14 Mechtilde 2009-03-12 13:29:19 UTC
verified im CWS Build ooo31gsl5 auf dem Buildbot Ubuntu-7.10-i386
Comment 15 philipp.lohmann 2009-03-12 14:13:46 UTC
Thanks for verification !
Comment 16 marc.neumann 2009-03-16 09:19:03 UTC
also verified on my ubuntu box with xfce
Comment 17 michael.ruess 2009-04-02 10:18:36 UTC
Looks fixed in OOO310m8 on my ubuntu notebook.
Comment 18 amy2008 2009-04-17 04:31:34 UTC
Verified in OOo310m9 on WinXP and Fedora9
Li Meiying