Issue 101009 - Crash when turning off "Show changes" after "compare document"
Summary: Crash when turning off "Show changes" after "compare document"
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOO300m9
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 84292
  Show dependency tree
 
Reported: 2009-04-10 09:43 UTC by amy2008
Modified: 2013-08-07 14:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description amy2008 2009-04-10 09:43:27 UTC 
Can reproduce it in OOo310m9 on WinXP and 

How to reproduce it
1 Create a new writer file, Insert - Section - click "Insert" button, then save
  the file as section.odt
2 Create another new writer file, input some characters like "testing", Edit -
  Compare Document, Accept and Reject Changes dialog appears, close it.
3 Edit - Changes - uncheck show

Result
OOo crashes

Expected
OOo works well

Regards
Li Meiying
Comment 1 amy2008 2009-04-14 05:55:45 UTC 
The ID of the error report is rbstmvc.
Comment 2 michael.ruess 2009-04-15 08:51:23 UTC 
As described, create a document containing a section, create another document
and type some characters, then Edit.Compare with the section document, turn off
"Show changes" -> crash.

MRU->MBA: please assign to developer now responsible for Redlining. Thanks!
Comment 3 Mathias_Bauer 2010-05-14 13:08:23 UTC 
Please take over
Comment 4 mst.ooo 2010-05-17 14:56:44 UTC 
the problem is that the delete redline that is created by document compare
includes the special EndOfContent node.
i believe redlines must not start/end on special start/end nodes.

fixed in cws sw33bf04
http://hg.services.openoffice.org/hg/cws/sw33bf04/rev/c9fba0887c9b
Comment 5 mst.ooo 2010-05-27 11:08:22 UTC 
please verify
Comment 6 michael.ruess 2010-05-31 15:29:18 UTC 
Verified in CWS sw33bf04.
Comment 7 michael.ruess 2010-08-27 12:14:34 UTC 
Checked in OOO330m5.