Issue 101879 - Add office version to SOAP-text
Summary: Add office version to SOAP-text
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO310m11
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: hans_werner67
QA Contact: issues@framework
URL:
Keywords: usagetracking
Depends on:
Blocks: 90370 99999
  Show dependency tree
 
Reported: 2009-05-13 12:29 UTC by hans_werner67
Modified: 2009-10-06 10:43 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
proposed patch (1.21 KB, text/plain)
2009-08-27 17:37 UTC, bjoern.michaelsen
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description hans_werner67 2009-05-13 12:29:56 UTC
Please add office-version information, e.g. 'OpenOffice.org 3.1' in the
SOAP-text, required to increase import-performance for usagetracking-reports.

Thanks,
Frank
Comment 1 hans_werner67 2009-05-13 12:31:51 UTC
Blocks i90370
Comment 2 hans_werner67 2009-05-13 12:35:52 UTC
It would be good to have this enhancement in version 3.1.1, so the target
milestone should be upgraded. Therefor CCed MD
Comment 3 hans_werner67 2009-05-29 11:06:49 UTC
added keyword
Comment 4 bjoern.michaelsen 2009-06-10 11:37:09 UTC
added usagetracking keyword
Comment 5 bjoern.michaelsen 2009-07-31 10:57:05 UTC
Where should the office version be added in the request? In which format?
Proposal:

...
xmlns:rds="urn:ReportDataService"
xmlns:apache="http://xml.apache.org/xml-soap"
SOAP-ENV:encodingStyle=\"http://schemas.xmlsoap.org/soap/encoding/">
<SOAP-ENV:Body>
<!-- Add Officeversion here -->
<rds:submitReport>
...

The OfficeVersion will be added as:
<Officeversion="SomeVersionString"/>

@fma: Would that work for you?
Comment 6 hans_werner67 2009-07-31 12:52:47 UTC
Yes, please in the SOAP-Body like:
Officeversion= MAJOR.MINOR.MICRO
Officeproduct= {OpenOffice.org, StarOffice, StarSuite, BrOffice.org,...}
Comment 7 bjoern.michaelsen 2009-07-31 13:52:11 UTC
Cant we just reuse the string as it gets written in the reportmail.xml?
Comment 8 hans_werner67 2009-07-31 14:25:17 UTC
If you mean
<officeinfo:officeinfo xmlns:officeinfo="http://openoffice.org/2002/officeinfo"
platform="Win32" language="es" build="310m11(Build:9399)" exceptiontype=""
product="OpenOffice.org 3.1 " />

-> product="OpenOffice.org 3.1 "
yes!!!

Cheers,
Frank
Comment 9 bjoern.michaelsen 2009-08-03 14:47:45 UTC
fixed in cws bjm02 with changeset 5699b326f2f1.

http://hg.services.openoffice.org/hg/cws/bjm02/rev/5699b326f2f1
Comment 10 bjoern.michaelsen 2009-08-12 17:07:00 UTC
Moved Office version from SOAP-Envelope-Body to request body with changeset
324d9e2690fb in cws bjm02

http://hg.services.openoffice.org/hg/cws/bjm02/rev/324d9e2690fb

@fma: please verify
Comment 11 eric.savary 2009-08-27 10:53:53 UTC
CCed: es
Comment 12 bjoern.michaelsen 2009-08-27 15:38:14 UTC
reopening as this wasnt completely fixed in bjm02
Comment 13 bjoern.michaelsen 2009-08-27 17:37:20 UTC
Created attachment 64416 [details]
proposed patch
Comment 14 bjoern.michaelsen 2009-08-27 18:06:01 UTC
attached proposed patch, changing issue type to patch
@mba: please reassign to someone to drop the patch in a 3.2 cws (after
integration of bjm02). cc'ing myself.
removing es from cc as this is not in cws bjm02 anymore
Comment 15 hans_werner67 2009-08-28 11:09:05 UTC
Patch works for me.
Frank
Comment 16 ivo.hinkelmann 2009-09-25 16:03:03 UTC
this issue was fixed on master for m60
Comment 17 bjoern.michaelsen 2009-09-25 18:14:57 UTC
reassigning to fma for validation on master (m60)
Comment 18 hans_werner67 2009-10-06 10:42:22 UTC
Verified, so we can prepare multiple import queues for the OOo
Comment 19 hans_werner67 2009-10-06 10:43:13 UTC
Closing issue