Issue 10237 - Change switches from /Dsomemacro to /Dsomemacro
Summary: Change switches from /Dsomemacro to /Dsomemacro
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 643C
Hardware: PC Windows 2000
: P3 Trivial (vote)
Target Milestone: ---
Assignee: Unknown
QA Contact: issues@tools
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2002-12-20 13:12 UTC by quetschke
Modified: 2003-03-16 20:14 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch for shell/source/win32/shlxthandler/makefile.mk (1.74 KB, patch)
2002-12-20 13:14 UTC, quetschke 		no flags Details | Diff
New patch for shell/source/win32/shlxthandler/makefile.mk (1.78 KB, patch)
2002-12-20 14:05 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description quetschke 2002-12-20 13:12:35 UTC 
Needed for w32/tcsh build.

For cl.exe /Dsomemacro and -Dsomemacro are equivalent, but the /Dxxx version
looks like a posix path for the w32/tcsh build. Use -Dxxx as every other compiler
does.

The 
    +$(BIN)$/lngconvex.exe -lng ..\..\source\win32\shlxthandler\shlxthdl.lng
line doesn't work, due to the \ in a tcsh shell, removing the "+" works.

The following patch fixes both problems.
Comment 1 quetschke 2002-12-20 13:14:05 UTC 
Created attachment 4126 [details]
Patch for shell/source/win32/shlxthandler/makefile.mk
Comment 2 quetschke 2002-12-20 13:18:52 UTC 
Approval pending added.

The patch above is for the OO643C branch, a similar patch
has to be added to the HEAD (644) version of the file.
Comment 3 hjs 2002-12-20 13:49:29 UTC 
i would prefer something like

$(WRAPCMD) $(BIN)$/lngconvex.exe -lng
..$/..$/source$/win32$/shlxthandler$/shlxthdl.lng -rc
..$/..$/source$/win32$/shlxthandler$/shlxthdl.rc -c
...

removing "+" at the begining of the line just don't force the
execution in a shell, but dmake is free to decide itself if it finds
some shell metas.
Comment 4 quetschke 2002-12-20 14:05:43 UTC 
Created attachment 4127 [details]
New patch for shell/source/win32/shlxthandler/makefile.mk
Comment 5 quetschke 2002-12-20 14:06:47 UTC 
Ok, new patch added, following your suggestions.
Comment 6 hjs 2002-12-20 14:52:45 UTC 
fine for me...
Comment 7 quetschke 2002-12-20 19:40:01 UTC 
Done!
Comment 8 michael.bemmer 2003-03-16 20:10:41 UTC 
As discussed with Armin, he thought these bug were closed, he sees all of them
as verified.
Comment 9 michael.bemmer 2003-03-16 20:14:19 UTC 
As discussed with Armin, he thought these bug were closed, he sees all of them
as verified.