Issue 105489 - regression: handling of custom toolbars is broken
Summary: regression: handling of custom toolbars is broken
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: DEV300m60
Hardware: PC Windows XP
: P2 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: thorsten.martens
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 99999
  Show dependency tree
 
Reported: 2009-09-30 19:58 UTC by Regina Henschel
Modified: 2017-05-20 10:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2009-09-30 19:58:10 UTC 
I have only tested Calc so far, but I think it is a framework problem.

Open Calc
Tools > Customize > Toolbars > New
Enter a name, for example 'MyBasic', and use option Save in Calc.
Add the command 'Edit macros'. It is in category 'Application'. Close. OK

Use the triangle-menu of the new toolbar and open 'Customize...'.
Notice that the name of the toolbar is no longe 'MyBasic' but something like
'custom_toolbar_78'.

Goto menu View > Toolbars. Notice that the toolbar is not listed there, neither
with name 'MyBasic' nor with name 'custom_toolbar_78'. That has the effect, that
you cannot open the toolbar once you have closed it, for example with 'Close
toolbar' from its triangle-menu.

This all works in OOo3.1.1 and at least till DEV300m55.
Comment 1 thorsten.martens 2009-10-01 10:51:15 UTC 
TM->CD: please have a look, it's reproducible.
Comment 2 carsten.driesner 2009-10-01 11:28:53 UTC 
cd->regina: Thanks for the info. I think this is clearly a show stopper. Usage
of custom toolbars is broken due to this issue.
Comment 3 Regina Henschel 2009-10-01 14:05:08 UTC 
I have tested some additional versions. It is OK in DEV300m57 and broken in
DEV300m58, both on WinXP.
Comment 4 carsten.driesner 2009-10-01 14:14:18 UTC 
cd->regina: Thanks for the info. I think it's clear that the optimization work
done by CWS oj18 introduced this regression.

cd: Set priority to P2 as custom toolbars are mainly broken due to this regression.
Comment 5 carsten.driesner 2009-10-02 10:42:30 UTC 
cd: Fixed. I revert all changes done in oj18 regarding the ui configuration
manager. Testing all things regarding custom toolbars revealed no issue.
Comment 6 carsten.driesner 2009-10-02 10:43:00 UTC 
cd: Set issue to OOo 3.2 blocker list.
Comment 7 carsten.driesner 2009-10-06 10:33:47 UTC 
cd->tm: Please verify. You should check the whole custom toolbar feature to be
sure that nothing went wrong. Although I revert all changes made by OJ.
Comment 8 carsten.driesner 2009-10-06 15:36:48 UTC 
Set owner to tm.
Comment 9 eric.savary 2009-10-09 18:26:40 UTC 
Verified in CWS fwk122