Issue 106412 - [From Symphony]Fix some issues about API: Range
Summary: [From Symphony]Fix some issues about API: Range
Status: CONFIRMED
Alias: None
Product: App Dev
Classification: Unclassified
Component: vba (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 08:11 UTC by lihuiibm
Modified: 2013-02-24 20:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Patch of module "sc" for this issue (13.84 KB, patch)
2009-10-29 08:12 UTC, lihuiibm
no flags Details | Diff
Patch of module "oovbaapi" for this issue (741 bytes, patch)
2009-10-29 08:12 UTC, lihuiibm
no flags Details | Diff
Test case sample for this patch.(Range.SpecialCells(xlLastCell)) (119.50 KB, text/plain)
2009-10-29 08:13 UTC, lihuiibm
no flags Details
Test case sample for this patch: Range.SpecialCells(xlCellTypeLastCell) (132.00 KB, text/plain)
2009-10-29 08:14 UTC, lihuiibm
no flags Details
Test case sample for this patch: Range.FormulaArray (79.50 KB, text/plain)
2009-10-29 08:15 UTC, lihuiibm
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description lihuiibm 2009-10-29 08:11:53 UTC
Following issues:

Issue 1. Range.SpecialCells(xlCellTypeLastCell) 
  Steps:
     1.1 Run the sample(Range_SpecialCells(xlCellTypeLastCell).xls) file in
attachments with OOo.
     1.2 See the log under <User Home>
  Defect:
    Range.SpecialCells(xlCellTypeLastCell) could not return the last activate value.

2. Range.SpecialCells(xlLastCell) 
  Steps:
      2.1 Run the sample(Range.SpecialCells(xlLastCell).xls) file in attachment
with OOo.
  Issue:
    Script code "range1.SpecialCells(xlLastCell).value" will lead to crash

3. Add new API Range.FormulaLocal

4. Range.FormularArray
     4.1 Run the sample(Range_TST-A5FA7B.xls) file in attachments with OOo.
     4.2 See the log under <User Home>
    For the problem of getting value from Range.FormularArray, it is because
that the OOo core function returns a string with a couple of bracket ("{}") at
the outside. So we must remove the bracket "{}"
Comment 1 lihuiibm 2009-10-29 08:12:31 UTC
Created attachment 65725 [details]
Patch of module "sc" for this issue
Comment 2 lihuiibm 2009-10-29 08:12:57 UTC
Created attachment 65726 [details]
Patch of module "oovbaapi" for this issue
Comment 3 lihuiibm 2009-10-29 08:13:45 UTC
Created attachment 65727 [details]
Test case sample for this patch.(Range.SpecialCells(xlLastCell))
Comment 4 lihuiibm 2009-10-29 08:14:37 UTC
Created attachment 65728 [details]
Test case sample for this patch: Range.SpecialCells(xlCellTypeLastCell)
Comment 5 lihuiibm 2009-10-29 08:15:09 UTC
Created attachment 65729 [details]
Test case sample for this patch: Range.FormulaArray
Comment 6 noel.power 2009-11-13 11:18:36 UTC
need some time to look at this
Comment 7 noel.power 2010-03-16 18:54:36 UTC
Range.SpecialCells changes look ok :-)

Range.FormulaLocal
not familiar with this api but... you've got a test, the change wont break
anything, I'm happy

Range.FormulaArray
seems reasonable

but...
there seems to be extra things in the patch

a) vbanames.cxx
   probably this is something that needs a seperate issue, testcase, description
etc.
b) vbaworksheet.cxx 
   the change here to the return value seems to do... nothing, was there some
problem here I am not aware of?