Issue 106487 - starmath: avoid an unending timer
Summary: starmath: avoid an unending timer
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: thomas.lange
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 106485
  Show dependency tree
 
Reported: 2009-10-30 13:19 UTC by caolanm
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
only set trigger when there is a change (681 bytes, patch)
2009-10-30 13:21 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-10-30 13:19:49 UTC
Starmath has a little timer that it uses to trigger the re-render of the
equation. But this timer always triggers itself to run again, so even if the
equation content hasn't changed it always fires. If we only trigger it when
there has been some event that requires it (say UI events or SetText) then we
save battery life by avoiding cpu wakeups.

How about the following trivial patch. AFAICS we already set the timeout on key
press and settext. (patches reduces the timeout time while we're at it as
rendering takes very little time on modern machines so makes starmath seem more
snappy, but that's not an important part)
Comment 1 caolanm 2009-10-30 13:21:05 UTC
Created attachment 65798 [details]
only set trigger when there is a change
Comment 2 thomas.lange 2009-11-03 08:33:29 UTC
.
Comment 3 thomas.lange 2009-11-06 09:57:14 UTC
.
Comment 4 thomas.lange 2009-11-06 10:16:24 UTC
tl->cmc: Thanks for the patch.

Patched in CWS tl74.
Comment 5 thomas.lange 2010-02-23 14:13:21 UTC
Verified.
Comment 6 thomas.lange 2010-07-02 11:09:38 UTC
Closing.