Issue 107205 - sfx2: remove SfxDispatcher::Popup and SfxPopupMenuManager::Popup
Summary: sfx2: remove SfxDispatcher::Popup and SfxPopupMenuManager::Popup
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m60
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 13:28 UTC by thomas.lange
Modified: 2017-05-20 10:55 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2009-11-25 13:28:04 UTC
Those two functions are only used for comments (formerly called annotations or
post-its) in sw/source/ui/docvw/postit.cxx.

Those functions should not exist and instead of calling Popup and Execute
separately in postit.cxx a single call to ExecutePopup should me made.
The problem however is that postit.cxx currently does some manual popup menu
interception in that code as well.
Thus we need a different solution to get the same result before we can remove
those two functions.
Comment 1 thomas.lange 2009-11-25 13:28:25 UTC
.
Comment 2 thomas.lange 2009-11-26 08:58:25 UTC
tl->mod: Can you take over for this one?
Comment 3 max.odendahl 2009-11-30 08:16:51 UTC
mod->tl: not sure what you are asking here. As far as I can see, the split is
neccessary to replace existing text inside the popup menu, which is currently
not possible to achieve otherwise, so these methods cannot be removed.
Comment 4 carsten.driesner 2009-12-01 10:39:52 UTC
cd->mod: Just for your information. I want to deprecate and in the end remove
the sfx2 context menu code. In the end it's bad to use internal code to
manipulate the menu. There is a official solution called context menu
interception where you change the menu at runtime. See here:

http://wiki.services.openoffice.org/wiki/Framework/Tutorial/Context_Menu_Interception

You can leave this issue open, which must be fixed when the current context menu
implementation will be completely changed.
Comment 5 thorsten.ziehm 2010-09-23 15:25:56 UTC
OOo 3.3 is in showstopper-mode. This issue doesn't look like a stopper for the
current release. I change the target to OOo 3.x. Please change the target
accordingly when a fix is near to be integrated into a code line or promote it
as stopper issues at the mailing list releases@openoffice.org, when it is urgent
enough for OOo 3.3.
Comment 6 Marcus 2017-05-20 10:55:37 UTC
Reset assigne to the default "issues@openoffice.apache.org".