Issue 107358 - vcl: uninitialized m_aDigitLanguage in PDF export
Summary: vcl: uninitialized m_aDigitLanguage in PDF export
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOO320m6
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: caolanm
QA Contact: issues@gsl
URL:
Keywords:
: 87669 104930 105912 108439 110118 (view as issue list)
Depends on:
Blocks: 87669 99999 100007 101715 105912
  Show dependency tree
 
Reported: 2009-12-01 15:43 UTC by caolanm
Modified: 2010-04-13 08:34 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
fix up (1.35 KB, patch)
2009-12-01 15:44 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-12-01 15:43:55 UTC
patch attached, valgrind says...

==9928== Conditional jump or move depends on uninitialised value(s)
==9928==    at 0x7BD0F18: OutputDevice::ImplPrepareLayoutArgs(String&, unsigned
short, unsigned short, long, int const*) const (outdev3.cxx:6378)
==9928==    by 0x7BDF8D4: OutputDevice::ImplLayout(String const&, unsigned
short, unsigned short, Point const&, long, int const*, bool) const
(outdev3.cxx:6503)
==9928==    by 0x7C3C049: vcl::PDFWriterImpl::drawText(Point const&, String
const&, unsigned short, unsigned short, bool) (pdfwriter_impl.cxx:7228)
==9928==    by 0x286AED67: PDFExport::ImplWriteActions(vcl::PDFWriter&,
vcl::PDFExtOutDevData*, GDIMetaFile const&, VirtualDevice&) (pdfexport.cxx:1592)
==9928==    by 0x286B0A97: PDFExport::ImplExportPage(vcl::PDFWriter&,
vcl::PDFExtOutDevData&, GDIMetaFile const&) (pdfexport.cxx:971)
==9928==    by 0x286B130B: PDFExport::ExportSelection(vcl::PDFWriter&,
com::sun::star::uno::Reference<com::sun::star::view::XRenderable>&,
com::sun::star::uno::Any&, MultiSelection,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int)
(pdfexport.cxx:245)
==9928==    by 0x286B4A60: PDFExport::Export(rtl::OUString const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(pdfexport.cxx:894)
==9928==    by 0x286AB7F0:
PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:126)
==9928==    by 0x286ACD12:
PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:185)
==9928==    by 0x5E82C70: SfxObjectShell::ExportTo(SfxMedium&) (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==    by 0x5E8B656: ??? (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==    by 0x5E8D4FC: ??? (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==  Uninitialised value was created by a heap allocation
==9928==    at 0x4A0515D: malloc (vg_replace_malloc.c:195)
==9928==    by 0x4011CA: ??? (in /usr/lib64/openoffice.org3/program/soffice.bin)
==9928==    by 0x4012D6: operator new(unsigned long) (in
/usr/lib64/openoffice.org3/program/soffice.bin)
==9928==    by 0x7C1DC18: vcl::PDFWriterImpl::push(unsigned short)
(new_allocator.h:89)
==9928==    by 0x286AF26A: PDFExport::ImplWriteActions(vcl::PDFWriter&,
vcl::PDFExtOutDevData*, GDIMetaFile const&, VirtualDevice&) (pdfexport.cxx:1746)
==9928==    by 0x286B0A97: PDFExport::ImplExportPage(vcl::PDFWriter&,
vcl::PDFExtOutDevData&, GDIMetaFile const&) (pdfexport.cxx:971)
==9928==    by 0x286B130B: PDFExport::ExportSelection(vcl::PDFWriter&,
com::sun::star::uno::Reference<com::sun::star::view::XRenderable>&,
com::sun::star::uno::Any&, MultiSelection,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int)
(pdfexport.cxx:245)
==9928==    by 0x286B4A60: PDFExport::Export(rtl::OUString const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(pdfexport.cxx:894)
==9928==    by 0x286AB7F0:
PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:126)
==9928==    by 0x286ACD12:
PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:185)
==9928==    by 0x5E82C70: SfxObjectShell::ExportTo(SfxMedium&) (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==    by 0x5E8B656: ??? (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==
==9928== Conditional jump or move depends on uninitialised value(s)
==9928==    at 0x7C62FF5: GetLocalizedChar(unsigned int, unsigned short)
(sallayout.cxx:308)
==9928==    by 0x7BD100D: OutputDevice::ImplPrepareLayoutArgs(String&, unsigned
short, unsigned short, long, int const*) const (outdev3.cxx:6390)
==9928==    by 0x7BDF8D4: OutputDevice::ImplLayout(String const&, unsigned
short, unsigned short, Point const&, long, int const*, bool) const
(outdev3.cxx:6503)
==9928==    by 0x7C3C049: vcl::PDFWriterImpl::drawText(Point const&, String
const&, unsigned short, unsigned short, bool) (pdfwriter_impl.cxx:7228)
==9928==    by 0x286AED67: PDFExport::ImplWriteActions(vcl::PDFWriter&,
vcl::PDFExtOutDevData*, GDIMetaFile const&, VirtualDevice&) (pdfexport.cxx:1592)
==9928==    by 0x286B0A97: PDFExport::ImplExportPage(vcl::PDFWriter&,
vcl::PDFExtOutDevData&, GDIMetaFile const&) (pdfexport.cxx:971)
==9928==    by 0x286B130B: PDFExport::ExportSelection(vcl::PDFWriter&,
com::sun::star::uno::Reference<com::sun::star::view::XRenderable>&,
com::sun::star::uno::Any&, MultiSelection,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int)
(pdfexport.cxx:245)
==9928==    by 0x286B4A60: PDFExport::Export(rtl::OUString const&,
com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&)
(pdfexport.cxx:894)
==9928==    by 0x286AB7F0:
PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:126)
==9928==    by 0x286ACD12:
PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>
const&) (pdffilter.cxx:185)
==9928==    by 0x5E82C70: SfxObjectShell::ExportTo(SfxMedium&) (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==    by 0x5E8B656: ??? (in
/usr/lib64/openoffice.org/basis3.2/program/libsfxlx.so)
==9928==  Uninitialised value was created by a heap allocation
==9928==    at 0x4A0515D: malloc (vg_replace_malloc.c:195)
==9928==    by 0x4011CA: ??? (in /usr/lib64/openoffice.org3/program/soffice.bin)
==9928==    by 0x4012D6: operator new(unsigned long) (in
/usr/lib64/openoffice.org3/program/soffice.bin)
==9928==    by 0x7C1DC18: vcl::PDFWriterImpl::push(unsigned short)
(new_allocator.h:89)
==9928==    by 0x286AF26A: PDFExport::ImplWriteActions(vcl::PDFWriter&,
vcl::PDFExtOutDevData*, GDIMetaFile const&, VirtualDevice&) (pdfexport.cxx:1746)
Comment 1 caolanm 2009-12-01 15:44:33 UTC
Created attachment 66439 [details]
fix up
Comment 2 philipp.lohmann 2009-12-01 17:02:36 UTC
committed in CWS vcl108
Comment 3 philipp.lohmann 2009-12-01 17:21:00 UTC
target
Comment 4 hdu@apache.org 2009-12-02 09:09:29 UTC
Good catch! This might explain issue 87669, issue 100007, issue 101715, issue 105912 and probably 
some more.
Comment 5 openoffice 2009-12-02 13:15:43 UTC
*** Issue 87669 has been marked as a duplicate of this issue. ***
Comment 6 philipp.lohmann 2009-12-04 12:15:58 UTC
Will also commit in CWS ooo32gsl09 for 3.2 since hdu thinks this can explain so
many issues (and the fix is obvious).
Comment 7 philipp.lohmann 2009-12-08 09:58:02 UTC
please verify in CWS ooo32gsl09
Comment 8 caolanm 2009-12-08 11:03:15 UTC
looks good to me anyway
Comment 9 hdu@apache.org 2009-12-23 12:15:58 UTC
*** Issue 105912 has been marked as a duplicate of this issue. ***
Comment 10 hdu@apache.org 2010-01-19 09:17:37 UTC
*** Issue 108439 has been marked as a duplicate of this issue. ***
Comment 11 caolanm 2010-02-04 10:17:16 UTC
closing, integrated OOO320 and DEV300 codelines
Comment 12 hdu@apache.org 2010-04-13 08:22:17 UTC
*** Issue 110118 has been marked as a duplicate of this issue. ***
Comment 13 hdu@apache.org 2010-04-13 08:34:20 UTC
*** Issue 104930 has been marked as a duplicate of this issue. ***