Issue 108458 - All Comments are hidden but Comment area remains
Summary: All Comments are hidden but Comment area remains
Alias: None
Product: Writer
Classification: Application
Component: viewing (show other issues)
Version: OOO320m9
Hardware: All All
: P3 Trivial with 2 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
Depends on:
Reported: 2010-01-19 14:12 UTC by mux2005
Modified: 2017-05-20 11:17 UTC (History)
3 users (show)

See Also:
Latest Confirmation in: ---
Developer Difficulty: ---

All annotations are hidden, but the annotation are remains an ugly stripe to the right of the document. (7.75 KB, application/vnd.oasis.opendocument.text)
2010-01-19 14:13 UTC, mux2005
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description mux2005 2010-01-19 14:12:04 UTC
Open the attached document. It contains one annotation but it is hidden. However
OOo still shows the annotation area to the right of the document and adjusts the
zoom factor accordingly. Ideally the annotation area should not be present at
all if no annotations are visible. If that is not possible, at least adjust the
zoom factor as if it were not there, so that it is scrolled out of view when
opening the document.
Comment 1 mux2005 2010-01-19 14:13:05 UTC
Created attachment 67295 [details]
All annotations are hidden, but the annotation are remains an ugly stripe to the right of the document.
Comment 2 michael.ruess 2010-01-20 08:10:18 UTC
It must be determined if there are still non-hidden comments in the document. I
think, that this is not implemented yet.
Comment 3 max.odendahl 2010-01-20 08:49:26 UTC
@christophnoack: should the sidepane be hidden if there are comments, but only
hidden ones?
Comment 4 christoph 2010-01-20 20:12:19 UTC
@mod: I don't get it :-) The feature of "hidden notes" isn't implemented in
Writer, is it? If not, is this a feature available in the Oasis specification? Bye!
Comment 5 max.odendahl 2010-01-20 23:41:18 UTC
yes, it is implemented. Select the anchor(or characters around it)and set the
character format to hidden, and you will not see the note anymore. (Note: this
is different from some earlier prototype, where you could select the popup
button and select "Hide Note")

The question here is: if all notes are hidden(in the sample document there is
only one note, which is hidden), should we show the sidebar or not
Comment 6 christoph 2010-01-25 22:28:07 UTC
@mod: The basic point is whether the user wants to know if there are any notes
in the document. I think this is a 50/50 decision here, since some users may
still want to know that there are notes in the document (e.g. when sending them
to other people; currently still shown in the Navigator) or if they want to hide
everything because it disturbs them during work (no problem, since the side pane
can easily been deactivated in an editable document).

If we would have the Document Check I proposed, I would go for hiding the side
pane per default. But without this functionality and with regard to our
decisions so far (being very cautious with regard to hidden information) we
might keep it. Finally, I don't know real _reasons_ to go for this/that. The
best solution so far would even be to mark the sidepane with something like
"Document contains hidden notes" to make clear why it is shown. As you may have
noticed, completely different from what has been proposed initially :-)
Comment 7 max.odendahl 2010-01-26 09:05:53 UTC
ok, I guess no strong points for either one and just a matter of taste. If we
change it, I'm sure people will complain that they missed a comment. Worth an
option? I guess not!

-> resolved wontfix

If anything new comes up, we can always reopen
Comment 8 max.odendahl 2010-01-26 09:06:21 UTC
Comment 9 mux2005 2010-01-26 16:03:53 UTC
I don't buy the "people will complain that they missed a comment" argument. When
the document creator has hidden a comment, then the comment is obviously not
meant for consumption by receivers of the document who are not told specifically
about it. Why else would he have hidden the comment?
You are thinking about techies. Those can use the navigator to find all comments.

About not being worth an option. That's a good point, but we already have an
option for it that is perfectly applicable. It's the option to show hidden text.
Obviously this should make the side pane with the comments re-appear because it
makes the text the comments are attached to appear. This further eliminates your
argument that people could be bothered by missing a comment. There is no
indication that there is any hidden text in a document unless you decide to turn
on the option to show it. So far, no one has complained. I don't see how
comments should be different from the main text. And if I may remind you, before
the side pane was introduced, comments were exactly like text. The little boxes
disappeared completely when the text was invisible, unless showing hidden text
was enabled. All I want is to have the old behaviour back. If it was okay back
then, it's okay now.

We have to scenarios where hidden comments come into play. The first one is when
parts of a document are hidden/unhidden on demand (through an interactive
extension) and comments related to hidden text are not supposed to be read
(because they don't apply). The second are comments that contain data only for
consumption by our extension.

In both cases I don't want the user experience to suffer by a sub-optimal zoom
factor and an empty side panel that will confuse ordinary users (who wonder if
this is a graphic bug and they should be seeing something there), but this is
what OOo currently does.
Comment 10 max.odendahl 2010-01-26 18:26:16 UTC
>About not being worth an option. That's a good point, but we already have an
>option for it that is perfectly applicable. It's the option to show hidden text.
>Obviously this should make the side pane with the comments re-appear because it
>makes the text the comments are attached to appear. 

@christophnoack: makes sense to me, do you agree?
Comment 11 christoph 2010-01-27 21:29:40 UTC
@mod: As I already said, it seems to be a 50/50 decision. So we don't do
additional harm when changing it - if you like. But before you start and just
for clarification: This should then also work for a) viewing hidden text with
viewing Non-printing Characters activated, b) un-hiding text via default format,
c) changing hidden status via styles. What I don't know at the moment: What will
happen if the user explicitly activates View -- Notes (which is an active
element). Then, the user definitively wants to see the notes. Any ideas? 

@mux2005: If you buy it or not ;-) Comments are often used to just put together
some rough thoughts which might not be too kind, well formulated, ... In
contrast, people are more aware of the main text to be viewable by others. That
is one of the basic principles for the design of the notes.

Bye, Christoph
Comment 12 mux2005 2010-01-28 09:31:32 UTC
As I've said, all I want is the old pre-sidebar behaviour back with respect to
invisibility. If there are any ambiguities, just do what OOo 2.x did in the same
Comment 13 Marcus 2017-05-20 11:17:57 UTC
Reset assigne to the default "".