Created attachment 67574 [details]
Changes for the new API

rather than introduce another 'GetDocShellFromRange' into vbacomment.cxx why
don't you make 'GetDocShellFromRange' available from excelhelper of some other
global accessible place

Created attachment 68061 [details]
Change the code according to Noel's comment, and remove windows crlf(s), please use the new patch.

right so you did add this method to a global place thanks, actually I thought
when I looked at the patch last time I thought that you were cut'n'pasting one
of the variants of getDocShellFromRange, getDocShellFromIf etc. from
vbarange.cxx, the  'GetDocShellFromRange' But I was wrong your
GetDocShellFromRange uses ScCellRangesBase::getImplementation ( which I didn't
know about ) and this is imho *much* better than those other functions in (
getDocShellFromRange, getDocShellFromIf etc. ) mentioned above.

So, please can you commit this, additionally can you make remove the (
getDocShellFromRange, getDocShellFromIf etc ) from vbarange.cxx and make sure
the code there uses your better implementation you have added to excelvbahelper ?

this patch also needs to go upstream, nice solution thanks!!!

Created attachment 68306 [details]
New patch for this issue. Fix up according to Noel's comments, move "getDocShellFromIf, getDocShellFromRange, getModelFromXIf, getModelFromRange, getDocumentFromRange" from vbarange.cxx to excelvbahelper.cxx

Please use the latest patch "patch_new2.diff", did following changes:
1. Remove getDocShellFromIf(), getDocShellFromRange(), getModelFromXIf(),
getModelFromRange(), getDocumentFromRange() from vbarange.cxx.
2. Add GetDocShellFromRange(), GetDocumentFromRange(), GetModelFromRange() to
excelvbahelper.hxx and excelvbahelper.cxx.

Perhaps also a [From Symphony] issue?

Reset assigne to the default "issues@openoffice.apache.org".