Issue 109372 - Calc loses comments after inserting rows
Summary: Calc loses comments after inserting rows
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: OOO320m12
Hardware: Unknown All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: kla
QA Contact: issues@sc
Depends on:
Blocks: 109046
  Show dependency tree
Reported: 2010-02-17 15:20 UTC by bormant
Modified: 2013-08-07 15:15 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

proposed patch that seems to fix this problem (1.58 KB, patch)
2010-02-17 15:37 UTC, kyoshida
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description bormant 2010-02-17 15:20:10 UTC or linux fedora 12
OOo.3.2 OOO320m12
OOo-dev.3.3 DEV300m71

1) start Calc
2) menu Insert - Comment - type something
3) click on A1 cell - Ctrl+C (copy)
4) select A2:A20 - Ctrl+V (paste)
5) Ctrl+S (save)

Experiment 1, after preparation:
6) select A1
7) menu Insert - Rows
8) Ctrl+S (save)
9) menu File - Reload

Result: some comments was lost (A2, A4, A6, ... after insert).

Experiment 2, after preparation:
6) select A1:A3
7) menu Insert - Rows
8) Ctrl+S (save)
9) menu File - Reload

Result: some comments was lost (A4:A6, A10:A12, A16:18 after insert).
Comment 1 kyoshida 2010-02-17 15:36:19 UTC
yes, I noticed this one too.
Comment 2 kyoshida 2010-02-17 15:37:23 UTC
Created attachment 67880 [details]
proposed patch that seems to fix this problem
Comment 3 kyoshida 2010-02-17 15:39:02 UTC
That patch appears to fix this.  My own testing also indicates that it does not
cause any other issues, but of course my testing is not as comprehensive as full
QA testing.
Comment 4 denis0 2010-02-18 08:16:59 UTC
Confirm problem
ALTLinux + OOo 3.1.1 OOO310m19, build 9420
Comment 5 uwe.luebbers 2010-03-29 18:10:41 UTC
Adjusted target
Comment 6 daniel.rentz 2010-03-30 09:29:41 UTC
This patch would break updating the note position when changing wow heights /
column widths.
Comment 7 daniel.rentz 2010-03-30 10:43:50 UTC
changing back issue type to defect
Comment 8 daniel.rentz 2010-03-31 10:45:21 UTC
Comment 9 daniel.rentz 2010-03-31 10:47:52 UTC
fixed in CWS OOO320/calc321stopper1

The committed fix adds a new boolean parameter to various document, table, and
drawing layer functions that specifies whether to update the cell position in
note caption objects.
Comment 10 daniel.rentz 2010-03-31 16:28:03 UTC
back to QA
Comment 11 kla 2010-04-06 13:48:48 UTC
Seen ok in cws, all comment are correct after reload.
Comment 12 wope 2010-05-01 17:30:36 UTC
ok in DEV300_m15, issue closing