Issue 109773 - [Notes2] Cannot change default style of a comment (font, size, ...)
Summary: [Notes2] Cannot change default style of a comment (font, size, ...)
Status: CONFIRMED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 3.2
Hardware: All All
: P3 Trivial with 17 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 127933 (view as issue list)
Depends on:
Blocks:
 
Reported: 2010-03-03 13:20 UTC by mloiseleur
Modified: 2018-11-12 10:07 UTC (History)
8 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mloiseleur 2010-03-03 13:20:07 UTC
The "DejaVu Sans" font is the default font used for Notes under Linux. Microsoft
Office use "Arial" font, with an other size. If one exchange document between
those 2 softwares, the notes won't display nicely : they use different font.

Between some specific versions and specific OS, it can even become quite ugly to
see. It would be nice to add this settings into "Tools->Options->Writer->Default
Police", like the others.

Regards,
Comment 1 eric.savary 2010-03-03 13:47:22 UTC
The comments use the UI font.
I don't see really a need for such an option. Maybe when printing the comments?

Christoph: please have a look.
Comment 2 sgautier.ooo 2010-03-03 14:08:56 UTC
adding me to cc - Sophie
Comment 3 Mathias_Bauer 2010-03-03 14:29:31 UTC
If we wanted to support changing the font we should have a style for it.
Unfortunately this doesn't work ATM as Writer styles are not compatible with
EditEngine styles. So all in all this is quite some effort. Not a WONTFIX, but
definitely an OOoLater.
Things may change in case other, more important problems force us to make the
styles of Writer and EditEngine compatible.
Comment 4 mloiseleur 2010-03-03 14:57:20 UTC
Removing sophi of CC, since I was thinking about sgauti 
Comment 5 christoph 2010-03-03 19:42:23 UTC
Hi everyone! I can only support mba's statement - we discussed that several
times in the past. We can neither use styles, nor can we fully ignore fonts
(e.g. use only the system font in any case).
Comment 6 mloiseleur 2010-03-04 09:05:54 UTC
Those facts seems quite problematic :s. 

christophnoack: Is there an issue opened about this merge of Styles management
between Writer and EditEngine ? I have tried to search one, but without any
success so far.
Comment 7 Mathias_Bauer 2010-03-04 15:45:49 UTC
There is no such issue and ATM it wouldn't get a high priority, there are just
two many other, more important things to do.
Comment 8 wyth 2010-03-08 10:27:19 UTC
I'd love to see SOMETHING done with this. I'm just finishing grading over 40 
essays, and since the vast majority of students are writing documents in Word, 
that's what they're going to open their graded essays in.  But Word, the 
comments font is just too large.  I have to go through and change the font size 
for all of them... with over 40 essays, that's tedious, to say the least.

Just changing the font size from 10 to 8 makes a world of difference -- it even 
looks cleaner in OpenOffice. If there was a place/file to just make that 
alteration in the default Notes font, I'd gladly do that. Since we can change 
the font size for each individual note, it's at least possible.

Does anyone know where/which file contains the default font definitions for 
Notes? 
Comment 9 max.odendahl 2010-03-08 12:58:48 UTC
if you want to compile from source, just change 

aItem.Put(SvxFontHeightItem(200,100,EE_CHAR_FONTHEIGHT));

to 

aItem.Put(SvxFontHeightItem(200,80,EE_CHAR_FONTHEIGHT));

inside SwMarginWin::DefaultItem() function, which is in file
sw/source/ui/docvw/postit.cxx
Comment 10 wyth 2010-03-10 23:12:29 UTC
Just wanted to follow up on this, in reply to mod.

First, thanks very much for the tip. That's exactly the kind of thing I'm
looking for.

Second, I'm on Ubuntu; I downloaded the source code for the current stable
version of Writer in the standard repos (3.1), and the code you suggested wasn't
in postit.cxx.  I'm assuming your code might be for Windows. 

However, I found five places in the postit.cxx I downloaded that contained
SvxFontHeightItem(200,100,EE_CHAR_FONTHEIGHT):

* SfxItemSet item(aShell->GetPool());
* void SwMarginWin::ResetAttributes()
* void SwPostIt::SetPostItText()
* View()->GetEditView().RemoveAttribsKeepLanguages(true);
<<--- this last one is commented out in the file --->>
* Engine()->Clear();

I'm also assuming that postit.cxx controls note appearance, so any/all of these
sections are telling OpenOffice how to render the note font.

Unfortunately, I'm completely new to tinkering inside OpenOffice source code,
although I'm not afraid to dive in.  I spent a sleepless but interesting night
trying to find out how, but gave up after a few hours. (As my previous post may
indicate, I teach writing, and I'm just not versed in this stuff.) Short of
removing the standard 3.1 version and compiling it all again from source, I'm
not positive how I could simply edit this one file and then recompile what I
already have installed.   

I'm not asking for any step-by-step instructions from anyone, but if there are
any guides or quick references on how to just edit that one source file and then
recompile what I already have installed, I'd be grateful (I've already been to
the developer's guide)... This would be much easier if there was simply a config
file someplace that controlled the note appearance, like in /home/user/.openoffice. 

Oh -- and I'm assuming since SwMarginWin::DefaultItem() wasn't in postit.cxx,
the one I should be focusing on is SwPostIt::SetPostItText()? 
Comment 11 max.odendahl 2010-03-11 07:29:16 UTC
find the latest code here:

http://hg.services.openoffice.org/DEV300/file/2e46017e2878/sw/source/ui/docvw/postit.cxx

For information how to build OOo, see the building guide here:

http://wiki.services.openoffice.org/wiki/Documentation/Building_Guide

PS: for other development questions, please use the appropiate mailing list
Comment 12 mmartin_bln 2010-03-19 09:39:43 UTC
Voted for this one as it affects me, too.

I'm currently working on a presentation talk script, making heavy use of Notes to write down ideas for 
the slides and visuals. What happens is that Notes begin linig up vertically and pushing down much 
more than the text.

For my screen, I'd like to reduce the font size for notes generally, since I could cope with 7 or 8 pt if 
I'd get physically smaller notes in return. But it's very frustrating to change the font size for every 
note manually.
Comment 13 wyth 2010-03-23 16:16:32 UTC
Hi mmartin,

I came close to figuring out how to edit the appropriate cxx file and recompile, 
but there are no simple solutions for this; most of what I've gathered is spread 
out across a scree of different pages here and on the web, and each time I've 
tried to recompile I've gotten an error.

I'm in the middle of a massive grading crunch, and since I can't really use 
OO.org's notes, I've gone back to Word in a virtual machine for the time being. 
When I'm through with this round of grading, I'm going to take another crack at 
it. I'm no developer and this is all new territory for me, but it's a hell of an 
itch that no one else is scratching, so maybe I can come up with a patch.
Comment 14 wyth 2010-03-23 16:20:35 UTC
edit: I should say I _did_ alter the right postit.cxx file, which is buried in a 
tar.bz2 file in the source code. But recompiling failed.
Comment 15 rakbar 2010-03-29 11:59:43 UTC
In previous version it was allowed to change the style of the note. 
In v. 3.2 I can not change the style of the note which is already inserted. All
I can do is selecting a font (and its size) at the beginning of note creation.

It is not a minor bug for me, because it was available before and it is a
feature which i use frequently. Please fix it!
Comment 16 Rob Weir 2013-07-30 02:39:26 UTC
Reset assignee on issues not touched by assignee in more than 1000 days.
Comment 17 oooforum (fr) 2018-11-12 10:07:15 UTC
*** Issue 127933 has been marked as a duplicate of this issue. ***