Issue 109878 - bridges: Job has no virtual dtor, and various things inherit from it
Summary: bridges: Job has no virtual dtor, and various things inherit from it
Status: CLOSED FIXED
Alias: None
Product: udk
Classification: Code
Component: code (show other issues)
Version: DEV300m73
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: Stephan Bergmann
QA Contact: issues@udk
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2010-03-06 15:47 UTC by caolanm
Modified: 2010-05-28 10:18 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
inherit privately (1.12 KB, patch)
2010-03-06 15:47 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2010-03-06 15:47:01 UTC 
So cppcheck warns, worrying that someone may delete an inheriter via base
pointer. Attached is a patch to inherit privately, removing that possibility.
Alternatively adding a virtual dtor would obviously also clear the warning
Comment 1 caolanm 2010-03-06 15:47:34 UTC 
Created attachment 68188 [details]
inherit privately
Comment 2 kay.ramme 2010-03-09 13:39:01 UTC 
Stephan, could you add this to one of you CWS? Thanks.
Comment 3 Stephan Bergmann 2010-03-09 13:48:16 UTC 
.
Comment 4 Stephan Bergmann 2010-03-12 12:04:53 UTC 
applied attached bridges.cppcheck.novdtor.patch as
<http://hg.services.openoffice.org/cws/sb121/rev/a907ec96dc1c>
Comment 5 Stephan Bergmann 2010-03-29 12:28:28 UTC 
.
Comment 6 Stephan Bergmann 2010-05-28 10:18:38 UTC 
.